Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2407] Backport #5644 #5650

Merged
merged 2 commits into from
Sep 9, 2024
Merged

[stable2407] Backport #5644 #5650

merged 2 commits into from
Sep 9, 2024

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Sep 9, 2024

Backport #5644 into stable2407 (cc @bkchr).

@bkchr @github-actions
pallet-utility: Improve weight annotations (#5644)
9533183 
Prevent allocations when calculating the weights.

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
(cherry picked from commit f4eb417)
@github-actions github-actions bot requested a review from a team as a code owner September 9, 2024 12:54
@github-actions github-actions bot mentioned this pull request Sep 9, 2024
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 9, 2024
@ggwpez
CI wakeup
f2dd3e1 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@github-actions GitHub Actions
Copy link
Author

github-actions bot commented Sep 9, 2024

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@ggwpez ggwpez merged commit 6e4f07c into stable2407 Sep 9, 2024
147 of 163 checks passed
@ggwpez ggwpez deleted the backport-5644-to-stable2407 branch September 9, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@franciscoaguirre franciscoaguirre franciscoaguirre approved these changes

Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franciscoaguirre @ggwpez @bkchr