Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2409] Backport #5678 #5691

Merged
merged 1 commit into from
Sep 12, 2024
Merged

[stable2409] Backport #5678 #5691

merged 1 commit into from
Sep 12, 2024

Conversation

niklasad1
Copy link
Member

Backport #5678 into stable2409

@niklasad1 @ggwpez
rpc server: fix deny unsafe on RpcMethods::Auto (#5678)
814cd3d 
Close #5677

I made a nit when I moved this code:
https://github.com/paritytech/polkadot-sdk/blob/v1.14.0-rc1/substrate/client/service/src/lib.rs#L379-#L385
in #4792

Thus:
 - (ip.is_loopback(), RpcMethods::Auto) -> allow unsafe
 - (!ip.is_loopback(), RpcMethods::Auto) -> deny unsafe

---------

Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
@niklasad1
Copy link
Member Author

Seems like it was some issue with the backport bot and I decided to create this manually

@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@niklasad1 niklasad1 added the A3-backport Pull request is already reviewed well in another branch. label Sep 12, 2024
ggwpez
ggwpez approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea the bot broke again, but it is not that urgent, you can see the publish date here on the 25th: https://github.com/paritytech/release-registry/
But thanks anyway, am trying to get the bot up again 🫠

@ggwpez ggwpez merged commit 9330fc3 into stable2409 Sep 12, 2024
208 of 217 checks passed
@ggwpez ggwpez deleted the na-backport-5678 branch September 12, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niklasad1 @ggwpez