Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pallet-migrations: fix index access for singluar migrations #5695

Merged
merged 4 commits into from
Sep 13, 2024
Merged

pallet-migrations: fix index access for singluar migrations #5695

merged 4 commits into from
Sep 13, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Sep 12, 2024 •
edited
Loading

Discovered a bug in the migrations pallet while debugging paritytech/try-runtime-cli#90.
🚨 This can lead to your chain getting stuck. It happens when a single MBM is configured. Having no or more than one MBM will circumvent the issue.

Changes:

  • Check len of the tuple before accessing its nth_id
  • Make nth_id return None on unary tuples and n>0

@ggwpez
pallet-migrations: fix index access for singluar migrations
1d45ede 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez requested a review from a team as a code owner September 12, 2024 16:10
ggwpez
ggwpez commented Sep 12, 2024
View reviewed changes
substrate/frame/support/src/migrations.rs
@@ -777,8 +777,10 @@ impl<T: SteppedMigration> SteppedMigrations for T {
1
}

fn nth_id(_n: u32) -> Option<Vec<u8>> {
Some(T::id().encode())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the actual issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and this was not overwritten for a single migration that's not part of a tuple, right?

@ggwpez
Copy link
Member Author

ggwpez commented Sep 12, 2024

/cmd prdoc --pr 5695 --bump patch --audience "Runtime Dev"

@ggwpez ggwpez added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Sep 12, 2024
@ggwpez
doc
c35cd4c 
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@paritytech paritytech deleted a comment from github-actions bot Sep 12, 2024
@paritytech paritytech deleted a comment from github-actions bot Sep 12, 2024
georgepisaltu
georgepisaltu approved these changes Sep 12, 2024
View reviewed changes
substrate/frame/support/src/migrations.rs
@@ -777,8 +777,10 @@ impl<T: SteppedMigration> SteppedMigrations for T {
1
}

fn nth_id(_n: u32) -> Option<Vec<u8>> {
Some(T::id().encode())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh and this was not overwritten for a single migration that's not part of a tuple, right?

@ggwpez ggwpez added this pull request to the merge queue Sep 13, 2024
Merged via the queue into master with commit 0136463 Sep 13, 2024
202 of 205 checks passed
@ggwpez ggwpez deleted the oty-pallet-migrations-fix branch September 13, 2024 12:17
@ggwpez ggwpez added the A4-needs-backport Pull request must be backported to all maintained releases. label Sep 13, 2024
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
@ggwpez @github-actions
pallet-migrations: fix index access for singluar migrations (#5695)
02ed9b1 
Discovered a bug in the migrations pallet while debugging
paritytech/try-runtime-cli#90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 0136463)
@ggwpez ggwpez added A4-needs-backport Pull request must be backported to all maintained releases. and removed A4-needs-backport Pull request must be backported to all maintained releases. labels Sep 13, 2024
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
@ggwpez @github-actions
pallet-migrations: fix index access for singluar migrations (#5695)
75db8ab 
Discovered a bug in the migrations pallet while debugging
paritytech/try-runtime-cli#90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 0136463)
@ggwpez ggwpez added A4-needs-backport Pull request must be backported to all maintained releases. and removed A4-needs-backport Pull request must be backported to all maintained releases. labels Sep 16, 2024
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@ggwpez @github-actions
pallet-migrations: fix index access for singluar migrations (#5695)
331e7ca 
Discovered a bug in the migrations pallet while debugging
paritytech/try-runtime-cli#90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 0136463)
@paritytech-cmd-bot-polkadot-sdk
Copy link

Git push to origin failed for stable2407 with exitcode 1

github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@ggwpez @github-actions
pallet-migrations: fix index access for singluar migrations (#5695)
8781c7a 
Discovered a bug in the migrations pallet while debugging
paritytech/try-runtime-cli#90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 0136463)
@paritytech-cmd-bot-polkadot-sdk
Copy link

Successfully created backport PR for stable2409:

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Sep 16, 2024
Merged
@ggwpez ggwpez added A4-needs-backport Pull request must be backported to all maintained releases. and removed A4-needs-backport Pull request must be backported to all maintained releases. labels Sep 16, 2024
github-actions bot pushed a commit that referenced this pull request Sep 16, 2024
@ggwpez @github-actions
pallet-migrations: fix index access for singluar migrations (#5695)
b539e90 
Discovered a bug in the migrations pallet while debugging
paritytech/try-runtime-cli#90.
It only occurs when a single MBM is configured - hence it did not happen
when Ajuna Network tried it...

Changes:
- Check len of the tuple before accessing its nth_id
- Make nth_id return `None` on unary tuples and n>0

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: ggwpez <ggwpez@users.noreply.github.com>
(cherry picked from commit 0136463)
@paritytech-cmd-bot-polkadot-sdk
Copy link

Successfully created backport PR for stable2407:

@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Sep 16, 2024
Merged
@paritytech-cmd-bot-polkadot-sdk
Copy link

Git push to origin failed for stable2409 with exitcode 1

ggwpez added a commit that referenced this pull request Sep 16, 2024
@paritytech-cmd-bot-polkadot-sdk @ggwpez
[stable2409] Backport #5695 (#5728)
692daf4 
Backport #5695 into `stable2409` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez added a commit that referenced this pull request Sep 17, 2024
@paritytech-cmd-bot-polkadot-sdk @ggwpez
[stable2407] Backport #5695 (#5729)
e484c01 
Backport #5695 into `stable2407` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez removed the A4-needs-backport Pull request must be backported to all maintained releases. label Sep 17, 2024
This was referenced Sep 24, 2024
Merged
Closed
@TDemeco TDemeco mentioned this pull request Oct 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgepisaltu georgepisaltu georgepisaltu approved these changes

@seadanda seadanda seadanda approved these changes

@bkchr bkchr bkchr approved these changes

@claravanstaden claravanstaden claravanstaden approved these changes

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
Stable2409 LTS Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ggwpez @claravanstaden @bkchr @seadanda @georgepisaltu