pallet-treasury: Improve remove_approval benchmark
#5713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `SpendOrigin` doesn't return any `succesful_origin`, it doesn't mean that `RejectOrigin` will do the same. Thus, this pr fixes a potential wrong benchmarked weight for when `SpendOrigin` is set to e.g. `NeverOrigin`.
2 tasks
ggwpez
approved these changes
Sep 16, 2024
Ank4n
approved these changes
Sep 16, 2024
bkontur
approved these changes
Sep 16, 2024
lexnv
approved these changes
Sep 16, 2024
bkchr
added
the
A4-needs-backport
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-5713-to-stable2407
git worktree add --checkout .worktree/backport-5713-to-stable2407 backport-5713-to-stable2407
cd .worktree/backport-5713-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 9cdbdc5a73f3c2d1d9afdf266799f249c3c04c2d
git push --force-with-lease |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
When `SpendOrigin` doesn't return any `succesful_origin`, it doesn't mean that `RejectOrigin` will do the same. Thus, this pr fixes a potential wrong benchmarked weight for when `SpendOrigin` is set to e.g. `NeverOrigin`. (cherry picked from commit 9cdbdc5)
|
Successfully created backport PR for |
bkchr
added a commit
that referenced
this pull request
Sep 18, 2024
Backport #5713 into `stable2409` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Bastian Köcher <git@kchr.de>
bkchr
added a commit
that referenced
this pull request
Oct 7, 2024
Backport #5713 into `stable2407` from bkchr. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
SpendOrigindoesn't return anysuccesful_origin, it doesn't mean thatRejectOriginwill do the same. Thus, this pr fixes a potential wrong benchmarked weight for whenSpendOriginis set to e.g.NeverOrigin.