Replace lazy_static with LazyLock #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Sep 17, 2024
programskillforverification
changed the title
programskillforverification
force-pushed
the
replace-lazy-with-oncelock
branch
from
d59183d to
a9cc6d1
Compare
michalkucharczyk
approved these changes
Sep 23, 2024
bkchr
reviewed
Sep 29, 2024
Comment on lines
758
to
759
| static MSG: OnceLock<InboundDownwardMessage> = OnceLock::new(); | ||
| MSG.get_or_init(|| InboundDownwardMessage { sent_at: 1, msg: b"down".to_vec() }); |
There was a problem hiding this comment.
No need at all that this is OnceLock.
There was a problem hiding this comment.
@programskillforverification after this is done, we can merge it.
programskillforverification
force-pushed
the
replace-lazy-with-oncelock
branch
from
cbe75dd to
1196349
Compare
bkchr
reviewed
Sep 30, 2024
bkchr
reviewed
Sep 30, 2024
Merged
via the queue into
paritytech:master
with commit Sep 30, 2024
a8d8596
216 of 217 checks passed
paritytech-ci
pushed a commit
that referenced
this pull request
Oct 1, 2024
# Description close #5641 --------- Co-authored-by: Bastian Köcher <git@kchr.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #5641