Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Snowbridge initialize migration on Westend #5747

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Sep 18, 2024

Description

Fix #5074 which missed the runtime migration to initialize channels of the bridge.

@yrong yrong changed the title Snowbridge migration on westend [backport] Snowbridge on Westend Sep 18, 2024
@yrong yrong marked this pull request as ready for review September 18, 2024 05:05
@claravanstaden
Copy link
Contributor

This is not really a backport, so perhaps change the title to "Add Snowbridge initialize migration on Westend", otherwise the title is misleading.

@yrong yrong changed the title [backport] Snowbridge on Westend Add Snowbridge initialize migration on Westend Sep 18, 2024
@acatangiu acatangiu added T15-bridges This PR/Issue is related to bridges. A4-needs-backport Pull request must be backported to all maintained releases. labels Sep 18, 2024
@yrong
Copy link
Contributor Author

yrong commented Sep 19, 2024

https://github.com/paritytech/polkadot-sdk/actions/runs/10923847845/job/30321556177?pr=5747

check-runtime-migration(bridge-hub-rococo) fails though seems nothing to do with this PR. Tested with try-runtime-cli and it work as expected as follows:

➜  polkadot-sdk git:(snowbridge-westend-migration) ✗ RUST_LOG=ethereum_system try-runtime --runtime ./target/release/wbuild/bridge-hub-westend-runtime/bridge_hub_westend_runtime.compact.compressed.wasm on-runtime-upgrade --checks=pre-and-post live --uri wss://westend-bridge-hub-rpc.polkadot.io:443
✅ Found 6698 keys (3.23s)
[00:00:17] ✅ Downloaded key values 391.0557/s [====================================================================================================================================================] 6698/6698 (0s)
✅ Inserted keys into DB (0.03s)
[2024-09-19T01:40:40Z INFO  ethereum_system::migration] Agents and channels not initialized. Initialization will run.
[2024-09-19T01:40:40Z INFO  ethereum_system::migration] Ethereum system initialized.
[2024-09-19T01:40:40Z INFO  ethereum_system::migration] Ethereum system initialized.
[2024-09-19T01:40:40Z INFO  ethereum_system::migration] Agents and channels are initialized. Initialization will not run.
[2024-09-19T01:40:40Z INFO  ethereum_system::migration] Ethereum system already initialized. Skipping.

@acatangiu Is there anything required left for this PR?

@acatangiu
Copy link
Contributor

@yrong just some spurious network issues leading to some CI tests failing, restarted those CI jobs, should be auto-merged when they finish

@acatangiu acatangiu added this pull request to the merge queue Sep 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 19, 2024
@serban300 serban300 added this pull request to the merge queue Sep 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 20, 2024
@serban300 serban300 added this pull request to the merge queue Sep 20, 2024
Merged via the queue into paritytech:master with commit 86bb5cb Sep 20, 2024
208 of 210 checks passed
@paritytech-cmd-bot-polkadot-sdk

Created backport PR for stable2407:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-5747-to-stable2407
git worktree add --checkout .worktree/backport-5747-to-stable2407 backport-5747-to-stable2407
cd .worktree/backport-5747-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 86bb5cb5068463f006fda3a4ac4236686c989b86
git push --force-with-lease

github-actions bot pushed a commit that referenced this pull request Sep 20, 2024
# Description

Fix #5074 which missed
the runtime migration to initialize channels of the bridge.

---------

Co-authored-by: Adrian Catangiu <adrian@parity.io>
(cherry picked from commit 86bb5cb)
@paritytech-cmd-bot-polkadot-sdk

Successfully created backport PR for stable2409:

acatangiu pushed a commit that referenced this pull request Sep 20, 2024
Backport #5747 into `stable2409` from yrong.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Ron <yrong1997@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A4-needs-backport Pull request must be backported to all maintained releases. T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants