Reap pool member whose balance goes below ED #5769
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PieWol
reviewed
Sep 19, 2024
| } | ||
| } | ||
|
|
||
| Ok(()) |
There was a problem hiding this comment.
This is basically a service for the greater good of the chain. If the account has been successfully reaped it would make sense to return fees at the end.
| /// Remove the member if stake falls below the existential deposit. | ||
| #[pallet::call_index(26)] | ||
| // FIXME weight functions | ||
| #[pallet::weight(T::WeightInfo::reap_member_below_ed())] |
There was a problem hiding this comment.
you could just put a constant value in here before you create the benchmarks. then the compiler won't complain.
Ank4n
reviewed
Sep 19, 2024
| let pool = Pool::from(bonded_pool.bonded_account()); | ||
|
|
||
| // Ensure any dangling delegation is withdrawn. | ||
| let dangling_withdrawal = match T::StakeAdapter::member_delegation_balance(member.clone()) { |
There was a problem hiding this comment.
The general approach looks fine to me. Good next step would be to write an integration test (delegate-stake and transfer stake) to ensure the stake is updated and storages are cleaned as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5009
TODO
New to the pallet code. I'd appreciate it if you could take a look to see if it's on the right direction before I do the bench and tests @Ank4n