Avoid unnecessary state reset of allowed_requests when no block requests are sent
#5774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re sent Previously, the state of `allowed_requests` will always be reset to the default value even if there are no new block requests in the end. This could cause an edge cause that `peer_block_request()` will early return next time when no ongoing block requests in fact.
lexnv
reviewed
Sep 19, 2024
lexnv
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
LGTM! As always thanks for contributing 🙏
// cc @dmitry-markin would love to get your feedback on this thanks
Co-authored-by: Alexandru Vasile <60601340+lexnv@users.noreply.github.com>
dmitry-markin
approved these changes
Sep 20, 2024
Merged
via the queue into
paritytech:master
with commit Sep 20, 2024
515fcc9
202 of 208 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is cherry-picked from #5663 so that I can maintain a smaller polkadot-sdk diff downstream sooner than later.
cc @lexnv @dmitry-markin