Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor get_account_id_from_seed / get_from_seed to one common place #5804

Merged
merged 39 commits into from
Oct 17, 2024
Merged

Refactor get_account_id_from_seed / get_from_seed to one common place #5804

merged 39 commits into from
Oct 17, 2024

Conversation

programskillforverification
Copy link
Contributor

@programskillforverification programskillforverification commented Sep 23, 2024 •
edited by bkontur
Loading

Closes #5705

This was referenced Sep 27, 2024
Open
Merged
Merged
@iulianbarbu iulianbarbu mentioned this pull request Oct 1, 2024
Closed
@programskillforverification programskillforverification marked this pull request as ready for review October 1, 2024 15:31
@programskillforverification programskillforverification marked this pull request as draft October 1, 2024 15:31
@iulianbarbu iulianbarbu requested review from iulianbarbu and removed request for a team October 1, 2024 15:42
iulianbarbu
iulianbarbu reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@iulianbarbu iulianbarbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are usages of get_account_id_from_seed in templates/parachain/runtime/src/genesis_config_presets.rs, can you update this too?

Not sure what IDE you're using, but if it is using rust-analyzer it might see the errors there if you set WASM_BUILD_CARGO_ARGS="--message-format=json" in the environment before starting your IDE and waiting for a full build/indexing. Also, please mark this PR as ready for review as soon as you changed everything you wanted (merging it with latest master might be a good thing to do before then too).

@programskillforverification programskillforverification marked this pull request as ready for review October 7, 2024 09:19
michalkucharczyk
michalkucharczyk approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@michalkucharczyk michalkucharczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final nits sorry.
Looks good. Thank you!

@michalkucharczyk
Copy link
Contributor

I'd wait for @davxy opinion as this PR touches sp-core/crypto.

davxy
davxy approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@davxy davxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you

substrate/primitives/keyring/src/ed25519.rs Outdated Show resolved Hide resolved
substrate/bin/node/testing/src/keyring.rs Show resolved Hide resolved
cumulus/parachains/runtimes/assets/asset-hub-rococo/src/genesis_config_presets.rs Outdated Show resolved Hide resolved
@programskillforverification @michalkucharczyk
Update substrate/primitives/keyring/src/ed25519.rs
b1fcb7f 
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
@programskillforverification @michalkucharczyk
Update substrate/primitives/keyring/src/sr25519.rs
d9ca423 
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
@programskillforverification @michalkucharczyk
Update substrate/primitives/keyring/src/lib.rs
5860e2d 
Co-authored-by: Michal Kucharczyk <1728078+michalkucharczyk@users.noreply.github.com>
@iulianbarbu iulianbarbu added this pull request to the merge queue Oct 17, 2024
@iulianbarbu iulianbarbu removed this pull request from the merge queue due to a manual request Oct 17, 2024
@iulianbarbu iulianbarbu added this pull request to the merge queue Oct 17, 2024
Merged via the queue into paritytech:master with commit a2c7575 Oct 17, 2024
194 checks passed
@bkchr
Copy link
Member

bkchr commented Oct 18, 2024

/tip small

@substrate-tip-bot substrate-tip-bot
Copy link

@bkchr A referendum for a small (20 DOT) tip was successfully submitted for @programskillforverification (12gcYUJzFF4x2kdBAZu5zbRd6o7HitBb3iRMuiVtemYuvBEt on polkadot).

Referendum number: 1244.
tip

@substrate-tip-bot substrate-tip-bot
Copy link

The referendum has appeared on Polkassembly.

@programskillforverification
Copy link
Contributor Author

/tip small

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iulianbarbu iulianbarbu iulianbarbu approved these changes

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@davxy davxy davxy approved these changes

Assignees

@programskillforverification programskillforverification

Labels
T17-primitives Changes to primitives that are not covered by any other label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor get_account_id_from_seed / get_from_seed to one common place
5 participants
@programskillforverification @michalkucharczyk @bkchr @davxy @iulianbarbu