Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #5671 #5823

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #5671 into stable2409 from claravanstaden.

See the documentation on how to use this bot.

# Description

A fix for a border condition introduced with new feature
#5201. A malicious
relayer could spam the Ethereum client with sync committee updates that
have already been imported for the period. This PR adds a storage item
to track the last imported sync committee period, so that subsequent
irrelevant updates are not free.

Original PR: Snowfork#172

## Integration

Downstream projects are not affected. Relayers will not be able to spam
the Ethereum client with irrelevant sync committee updates for free.

## Review Notes

Adds a storage item to track the last free sync committee update period,
so that duplicate imports are not free.

---------

Co-authored-by: Adrian Catangiu <adrian@parity.io>
(cherry picked from commit 1790e42)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 24, 2024
@paritytech-review-bot paritytech-review-bot bot requested a review from a team September 24, 2024 13:01
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@claravanstaden
Copy link
Contributor

@acatangiu confirmed the Ethereum client pallet tests pass.

@acatangiu acatangiu merged commit bcb6e23 into stable2409 Sep 24, 2024
42 of 45 checks passed
@acatangiu acatangiu deleted the backport-5671-to-stable2409 branch September 24, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants