Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolochainDefaultConfig: Use correct AccountData #5941

Merged
merged 3 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions prdoc/pr_5941.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
title: "`SolochainDefaultConfig`: Use correct `AccountData`"

doc:
- audience: Runtime Dev
description: |
`SolochainDefaultConfig` by default was setting `AccountData` to `AccountInfo`.
Thus, the actual account data was recursively nested the same type. By default
it should be set `()`, because this is the only reasonable `AccountData`.

If you have used `SolochainDefaultConfig` before and did not overwrite, `AccountData`
you should now overwrite it to `AccountInfo` or you will need to write a migration to
change the data.

crates:
- name: frame-system
bump: patch
2 changes: 1 addition & 1 deletion substrate/frame/system/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ pub mod pallet {
type MaxConsumers = frame_support::traits::ConstU32<128>;

/// The default data to be stored in an account.
type AccountData = crate::AccountInfo<Self::Nonce, ()>;
type AccountData = ();

/// What to do if a new account is created.
type OnNewAccount = ();
Expand Down
Loading