Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use frame umbrella crate in pallet-proxy and pallet-multisig #5995

Merged
merged 44 commits into from
Oct 29, 2024
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
27df8ea
pallet-proxy
kianenigma Oct 9, 2024
8eefc00
pallet-multisig
kianenigma Oct 9, 2024
c151681
Merge branch 'master' of github.com:paritytech/polkadot-sdk into kiz-…
kianenigma Oct 9, 2024
78b52f2
better docs
kianenigma Oct 9, 2024
0305c59
Merge branch 'master' of github.com:paritytech/polkadot-sdk into kiz-…
kianenigma Oct 9, 2024
d253bc5
also improve the minimal template
kianenigma Oct 9, 2024
a4b1fd2
fix
kianenigma Oct 9, 2024
e0293d1
Update substrate/frame/multisig/src/migrations.rs
kianenigma Oct 15, 2024
253ce3f
Upgrade Proxy and Multisig pallets to Benchmarking V2 (#6018)
re-gius Oct 15, 2024
ff36c53
cleanup
kianenigma Oct 15, 2024
2d8323f
possibly how CI will look like
kianenigma Oct 15, 2024
687b61f
Master.into()
kianenigma Oct 16, 2024
49a4cc3
run_all_benchmarks.sh: format + use umbrella template when possible
re-gius Oct 21, 2024
4debb8e
Merge branch 'master' into kiz-frame-umbrella-in-pallets
re-gius Oct 21, 2024
556e8ea
fix Issue #6160
re-gius Oct 21, 2024
a6dfbed
remove unused code in multisig/benchmarking
re-gius Oct 21, 2024
645f2f4
fix `cmd.py` to use umbrella weights template only in `frame`
re-gius Oct 22, 2024
21cd6da
fix CI: handle empty output from `os.popen`
re-gius Oct 22, 2024
2c910cb
moving imports from support to umbrella crate
re-gius Oct 22, 2024
6e6f1ac
Revert "moving imports from support to umbrella crate"
re-gius Oct 22, 2024
bd17cf2
undo frame support prelude edits + fix imports
re-gius Oct 23, 2024
532ee9b
fix and fmt `Cargo.toml` files + remove duplicate import
re-gius Oct 23, 2024
d0120f2
Add prdoc
re-gius Oct 23, 2024
1e7d1bb
docs fix
re-gius Oct 23, 2024
4d8b583
Merge branch 'master' into kiz-frame-umbrella-in-pallets
re-gius Oct 23, 2024
cf32fbf
undo docs change
re-gius Oct 23, 2024
d460295
add docs comment + undo format for `run_all_benchmarks.sh`
re-gius Oct 24, 2024
ca35eed
Update substrate/frame/src/lib.rs
re-gius Oct 24, 2024
68c5eea
Merge branch 'master' into kiz-frame-umbrella-in-pallets
re-gius Oct 24, 2024
393d998
comment nit
re-gius Oct 24, 2024
2f5eea9
Update prdoc/pr_5995.prdoc
re-gius Oct 24, 2024
b85d644
Update substrate/frame/src/lib.rs
re-gius Oct 24, 2024
9e771ee
Update prdoc/pr_5995.prdoc
re-gius Oct 24, 2024
66d7396
Update prdoc/pr_5995.prdoc
re-gius Oct 24, 2024
88265e5
undo snowbridge changes
re-gius Oct 24, 2024
dc2973d
expand frame docs
re-gius Oct 24, 2024
8cd8c73
remove broken links from docs
re-gius Oct 24, 2024
5918bef
fix docs + add storage value to minimal template
re-gius Oct 24, 2024
325d62e
prdoc add missing pallet
re-gius Oct 24, 2024
801156c
Merge branch 'master' into kiz-frame-umbrella-in-pallets
re-gius Oct 24, 2024
48050fd
docs nit
re-gius Oct 25, 2024
d9f132b
Apply suggestions from code review
kianenigma Oct 25, 2024
61db970
Merge branch 'master' into kiz-frame-umbrella-in-pallets
kianenigma Oct 28, 2024
f5ba680
Merge branch 'master' into kiz-frame-umbrella-in-pallets
re-gius Oct 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into kiz-frame-umbrella-in-pallets
re-gius authored Oct 21, 2024

Verified

This commit was signed with the committer’s verified signature.
joshcooper Josh Cooper
commit 4debb8e5256d3b82bb81ef5b1a8ddcc8bc1b49d0
2 changes: 0 additions & 2 deletions substrate/frame/Cargo.toml
Original file line number Diff line number Diff line change
@@ -68,8 +68,6 @@ pallet-examples = { workspace = true }
default = ["runtime", "std"]
experimental = ["frame-support/experimental"]
runtime = [
"frame-executive",
"frame-system-rpc-runtime-api",
"sp-api",
"sp-block-builder",
"sp-consensus-aura",
15 changes: 13 additions & 2 deletions substrate/scripts/run_all_benchmarks.sh
Original file line number Diff line number Diff line change
@@ -111,8 +111,19 @@ for PALLET in "${PALLETS[@]}"; do
fi
TEMPLATE_FILE="./.maintain/${TEMPLATE_FILE_NAME}"

echo "[+] Benchmarking $PALLET with weight file $WEIGHT_FILE"
echo "$TEMPLATE_FILE"
# Special handling of custom weight paths.
if [ "$PALLET" == "frame_system_extensions" ] || [ "$PALLET" == "frame-system-extensions" ]
then
WEIGHT_FILE="./frame/system/src/extensions/weights.rs"
elif [ "$PALLET" == "pallet_asset_conversion_tx_payment" ] || [ "$PALLET" == "pallet-asset-conversion-tx-payment" ]
then
WEIGHT_FILE="./frame/transaction-payment/asset-conversion-tx-payment/src/weights.rs"
elif [ "$PALLET" == "pallet_asset_tx_payment" ] || [ "$PALLET" == "pallet-asset-tx-payment" ]
then
WEIGHT_FILE="./frame/transaction-payment/asset-tx-payment/src/weights.rs"
fi

echo "[+] Benchmarking $PALLET with weight file $WEIGHT_FILE";

OUTPUT=$(
$SUBSTRATE benchmark pallet \
You are viewing a condensed version of this merge commit. You can view the full changes here.