Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish polkadot-omni-node binary #6057

Merged
merged 12 commits into from
Oct 30, 2024
Merged

Publish polkadot-omni-node binary #6057

merged 12 commits into from
Oct 30, 2024

Conversation

serban300
Copy link
Contributor

Closes #5566

Publish the polkadot-omni-node binary

This is a best effort. I'm not very familiar with the release / publishing process and also not sure how to test this. @paritytech/release-engineering can you take a look on this PR please ?

@serban300 serban300 self-assigned this Oct 14, 2024
@serban300 serban300 requested review from a team as code owners October 14, 2024 15:46
@serban300 serban300 added R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”. labels Oct 14, 2024
@kianenigma
Copy link
Contributor

cc @EgorPopelyaev

@EgorPopelyaev
Copy link
Contributor

Yep, I'll check this, after the current release

@kianenigma kianenigma mentioned this pull request Oct 22, 2024
Merged
2 tasks
@iulianbarbu
Copy link
Contributor

iulianbarbu commented Oct 24, 2024 •
edited
Loading

Besides publishing a binary artifact on the GH release page I assume that the polkadot-omni-node binary crate publishing on crates.io will be covered by default (as in the pipeline already covers it) and we shouldn't add support for it, right? Just want to double check.

@iulianbarbu iulianbarbu mentioned this pull request Oct 24, 2024
Merged
3 tasks
@serban300
Copy link
Contributor Author

Besides publishing a binary artifact on the GH release page I assume that the polkadot-omni-node binary crate publishing on crates.io will be covered by default (as in the pipeline already covers it) and we shouldn't add support for it, right? Just want to double check.

I'm not completely familiar with the crates.io publishing process, but I assume so.

@EgorPopelyaev EgorPopelyaev added this pull request to the merge queue Oct 30, 2024
Merged via the queue into paritytech:master with commit 01936b3 Oct 30, 2024
193 of 196 checks passed
@kianenigma
Copy link
Contributor

Thank you for timely addressing this @EgorPopelyaev and @alvicsam!

If only #802 would also be done 🥹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvicsam alvicsam alvicsam approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@kianenigma kianenigma Awaiting requested review from kianenigma

Assignees

@serban300 serban300

Labels
R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

polkadot-omni-node: re-namings
5 participants
@serban300 @kianenigma @EgorPopelyaev @iulianbarbu @alvicsam