Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable2407] Backport #5599 #6068

Merged
merged 3 commits into from
Oct 25, 2024
Merged

[stable2407] Backport #5599 #6068

merged 3 commits into from
Oct 25, 2024

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]
Copy link

Backport #5599 into stable2407 from franciscoaguirre.

See the documentation on how to use this bot.

@franciscoaguirre @github-actions
Add assets in pool with native to query_acceptable_payment_assets's r…
c01630e 
…eturn (#5599)

`XcmPaymentApi::query_acceptable_payment_assets` is an API that returns
the assets that can be used to pay fees on the runtime where it's
called.
For relays and most system chains this was configured only as the native
asset: ROC and WND.
However, the asset hubs have the asset conversion pallet, which allows
fees to be paid in any asset in a pool with the native one.
This PR adds the list of assets in a pool with the native one to the
return value of this API for the asset hubs.

---------

Co-authored-by: Branislav Kontur <bkontur@gmail.com>
(cherry picked from commit d2ba567)
@paritytech-cmd-bot-polkadot-sdk paritytech-cmd-bot-polkadot-sdk bot mentioned this pull request Oct 15, 2024
Merged
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Oct 15, 2024
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or trivial (not sure audit).
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@franciscoaguirre
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 15, 2024 •
edited
Loading

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7578339 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-4bb1660c-8e9e-41b7-90b2-e31e693fa656 to cancel this command or bot cancel to cancel all commands in this pull request.

@paritytech-ci paritytech-ci requested review from a team and koute as code owners October 15, 2024 16:22
@command-bot
Copy link

command-bot bot commented Oct 15, 2024

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7578339 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7578339/artifacts/download.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 15, 2024 16:23
@franciscoaguirre
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Oct 15, 2024 •
edited
Loading

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7579415 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-574c805f-22e4-4649-81fe-229240d29afb to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 15, 2024

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7579415 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7579415/artifacts/download.

@franciscoaguirre franciscoaguirre enabled auto-merge (squash) October 25, 2024 17:27
@franciscoaguirre franciscoaguirre force-pushed the backport-5599-to-stable2407 branch 2 times, most recently from 17e0a39 to 8af22fe Compare October 25, 2024 17:43
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7646623

@franciscoaguirre franciscoaguirre merged commit fff69c3 into stable2407 Oct 25, 2024
118 of 160 checks passed
@franciscoaguirre franciscoaguirre deleted the backport-5599-to-stable2407 branch October 25, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@koute koute Awaiting requested review from koute

Assignees

@franciscoaguirre franciscoaguirre

Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franciscoaguirre @paritytech-cicd-pr @acatangiu