Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved TrustedQueryAPI signatures #6129

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Improved TrustedQueryAPI signatures #6129

merged 9 commits into from
Oct 21, 2024

Conversation

x3c41a
Copy link
Contributor

@x3c41a x3c41a commented Oct 18, 2024 •
edited
Loading

Changed returned type of API methods from Result<bool, xcm_runtime_apis::trusted_query::Error> to a typed one type XcmTrustedQueryResult = Result<bool, xcm_runtime_apis::trusted_query::Error>;
Follow-up of PR-6039

@x3c41a x3c41a added the T6-XCM This PR/Issue is related to XCM. label Oct 18, 2024
bkchr
bkchr reviewed Oct 20, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type should be exposed by the crate providing the runtime. Otherwise this pr is not very useful.

@x3c41a x3c41a requested a review from a team as a code owner October 21, 2024 07:45
@x3c41a x3c41a requested a review from bkchr October 21, 2024 07:49
@x3c41a @bkchr
Documented XcmTrustedQueryResult public type
a69905b 
Co-authored-by: Bastian Köcher <git@kchr.de>
acatangiu
acatangiu approved these changes Oct 21, 2024
View reviewed changes
prdoc/pr_6129.prdoc Outdated Show resolved Hide resolved
@acatangiu acatangiu enabled auto-merge October 21, 2024 13:02
@acatangiu acatangiu added this pull request to the merge queue Oct 21, 2024
Merged via the queue into master with commit 95483a8 Oct 21, 2024
189 of 193 checks passed
@acatangiu acatangiu deleted the improve_signature branch October 21, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@bkchr bkchr bkchr approved these changes

@franciscoaguirre franciscoaguirre Awaiting requested review from franciscoaguirre

Assignees
No one assigned
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@x3c41a @bkchr @acatangiu