Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CheckMetadataHash: make it constant time and compile error on wrong env variable #6141

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Improve CheckMetadataHash: make it constant time and compile error on wrong env variable #6141

merged 3 commits into from
Oct 20, 2024

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Oct 19, 2024

  • The compilation now panics if the optional compile-time environment variable RUNTIME_METADATA_HASH contains an invalid value.
  • The weight for the CheckMetadataHash transaction extension is more accurate as it is almost compile-time.

@gui1117 gui1117 requested a review from a team as a code owner October 19, 2024 17:14
@gui1117 gui1117 mentioned this pull request Oct 19, 2024
Closed
@gui1117 gui1117 added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 19, 2024
@gui1117 gui1117 enabled auto-merge October 20, 2024 14:30
@gui1117 gui1117 added this pull request to the merge queue Oct 20, 2024
Merged via the queue into master with commit 21b3a46 Oct 20, 2024
175 of 193 checks passed
@gui1117 gui1117 deleted the gui-check-metadata-hash-benchmarks branch October 20, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gui1117 @shawntabrizi @ggwpez