Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #6080 #6181

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6080 into stable2409 from franciscoaguirre.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6080-to-stable2409
git worktree add --checkout .worktree/backport-6080-to-stable2409 backport-6080-to-stable2409
cd .worktree/backport-6080-to-stable2409
git reset --hard HEAD^
git cherry-pick -x b4732add46910370443d092a3f479986060f6df5
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Oct 22, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 3/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7622557

…#6080)

A follow-up to #5599.
Assets in a pool with the native one are returned from
`query_acceptable_payment_assets`. Now those assets can be used in
`query_weight_to_asset_fee` to get the correct amount that needs to be
paid.

---------

Co-authored-by: command-bot <>
(cherry picked from commit b4732ad)
@franciscoaguirre franciscoaguirre force-pushed the backport-6080-to-stable2409 branch from afc4599 to 2186f81 Compare November 8, 2024 17:12
@franciscoaguirre franciscoaguirre marked this pull request as ready for review November 8, 2024 17:12
@franciscoaguirre
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Nov 8, 2024

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7726798 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 68-29cdffab-0c9b-43a7-86d5-f365680598c0 to cancel this command or bot cancel to cancel all commands in this pull request.

@paritytech-ci paritytech-ci requested review from athei, pgherveou, a team and koute as code owners November 8, 2024 17:35
@command-bot
Copy link

command-bot bot commented Nov 8, 2024

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7726798 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7726798/artifacts/download.

@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 8, 2024 17:36
acatangiu
acatangiu previously approved these changes Nov 11, 2024
@EgorPopelyaev EgorPopelyaev merged commit a6df7c7 into stable2409 Nov 12, 2024
105 of 182 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6080-to-stable2409 branch November 12, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants