-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pure state sync refactoring (part-1) #6249
Pure state sync refactoring (part-1) #6249
Commits on Oct 26, 2024
-
Extract
process_state_verified()
Simply move the code into a function. This function is responsible for storing the verified state response in the memory.
Configuration menu - View commit details
-
Copy full SHA for 66c01aa - Browse repository at this point
Copy the full SHA 66c01aaView commit details -
Extract
process_state_unverified()
Same as the last commit, just move the code into a new function.
Configuration menu - View commit details
-
Copy full SHA for 5238a15 - Browse repository at this point
Copy the full SHA 5238a15View commit details -
Extract
insert_child_trie_roots()
This will be reused in the subsequent commit.
Configuration menu - View commit details
-
Copy full SHA for d339b47 - Browse repository at this point
Copy the full SHA d339b47View commit details -
Configuration menu - View commit details
-
Copy full SHA for b24d486 - Browse repository at this point
Copy the full SHA b24d486View commit details -
Separate child_key_values and top_key_values in `process_state_verifi…
…ed()` Make it clearer about what data are written.
Configuration menu - View commit details
-
Copy full SHA for e274146 - Browse repository at this point
Copy the full SHA e274146View commit details -
Configuration menu - View commit details
-
Copy full SHA for 991e2cd - Browse repository at this point
Copy the full SHA 991e2cdView commit details -
Rewrite the same logic in
process_state_unverified()
in the way sam……e as `process_state_verified()`
Configuration menu - View commit details
-
Copy full SHA for 633cbd7 - Browse repository at this point
Copy the full SHA 633cbd7View commit details -
Rewrite the same piece in
process_state_verified()
We can see clearly the common logic between `process_state_verified()` and `process_state_unverified()`, which will be extracted further in the next commit.
Configuration menu - View commit details
-
Copy full SHA for a3f9f8f - Browse repository at this point
Copy the full SHA a3f9f8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f40e937 - Browse repository at this point
Copy the full SHA f40e937View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b67beb - Browse repository at this point
Copy the full SHA 7b67bebView commit details -
Important: unify the insertion of child key values
Before this commit, every commit is an equalvalent rewrite. This commit modifies the origin logic by moving the child_key_value in `process_state_verified()` to the same place in `process_state_unverified()`. Please review this very carefully.
Configuration menu - View commit details
-
Copy full SHA for bb447b2 - Browse repository at this point
Copy the full SHA bb447b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 887e3be - Browse repository at this point
Copy the full SHA 887e3beView commit details -
Configuration menu - View commit details
-
Copy full SHA for 633c46a - Browse repository at this point
Copy the full SHA 633c46aView commit details
Commits on Oct 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 755563b - Browse repository at this point
Copy the full SHA 755563bView commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b221b1c - Browse repository at this point
Copy the full SHA b221b1cView commit details
Commits on Nov 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 241f65a - Browse repository at this point
Copy the full SHA 241f65aView commit details