Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pure state sync refactoring (part-1) #6249

Merged
merged 16 commits into from
Nov 18, 2024

Commits on Oct 26, 2024

  1. Extract process_state_verified()

    Simply move the code into a function.
    
    This function is responsible for storing the verified state response in
    the memory.
    liuchengxu committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    66c01aa View commit details
    Browse the repository at this point in the history
  2. Extract process_state_unverified()

    Same as the last commit, just move the code into a new function.
    liuchengxu committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    5238a15 View commit details
    Browse the repository at this point in the history
  3. Extract insert_child_trie_roots()

    This will be reused in the subsequent commit.
    liuchengxu committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    d339b47 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b24d486 View commit details
    Browse the repository at this point in the history
  5. Separate child_key_values and top_key_values in `process_state_verifi…

    …ed()`
    
    Make it clearer about what data are written.
    liuchengxu committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    e274146 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    991e2cd View commit details
    Browse the repository at this point in the history
  7. Rewrite the same logic in process_state_unverified() in the way sam…

    …e as `process_state_verified()`
    liuchengxu committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    633cbd7 View commit details
    Browse the repository at this point in the history
  8. Rewrite the same piece in process_state_verified()

    We can see clearly the common logic between `process_state_verified()`
    and `process_state_unverified()`, which will be extracted further in the
    next commit.
    liuchengxu committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    a3f9f8f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f40e937 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7b67beb View commit details
    Browse the repository at this point in the history
  11. Important: unify the insertion of child key values

    Before this commit, every commit is an equalvalent rewrite.
    
    This commit modifies the origin logic by moving the child_key_value
    in `process_state_verified()` to the same place in `process_state_unverified()`.
    
    Please review this very carefully.
    liuchengxu committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    bb447b2 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    887e3be View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    633c46a View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2024

  1. Nit

    liuchengxu committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    755563b View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Apply review suggestions

    liuchengxu committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    b221b1c View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2024

  1. Add prdoc

    liuchengxu committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    241f65a View commit details
    Browse the repository at this point in the history