-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FRAME: Meta Transaction #6428
base: master
Are you sure you want to change the base?
FRAME: Meta Transaction #6428
Conversation
Info = DispatchInfo, | ||
PostInfo = PostDispatchInfo, | ||
RuntimeOrigin = <Self as Config>::RuntimeOrigin, | ||
> + IsType<<Self as frame_system::Config>::RuntimeCall>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we no longer need to copy types like this. We can get rid of RuntimeCall
and RuntimeOrigin
associated types here and directly bound the frame system config supertrait:
pub trait Config: frame_system::Config<
RuntimeCall: Parameter
+ GetDispatchInfo
+ Dispatchable<
Info = DispatchInfo,
PostInfo = PostDispatchInfo,
RuntimeOrigin = <Self as Config>::RuntimeOrigin,
>,
RuntimeOrigin: AsTransactionAuthorizedOrigin
+ From<SystemOrigin<Self::AccountId>>
>
{
...
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these types of bounds are unstable, CI jobs failing, I left them unchanged for now
bot help |
Here's a link to docs |
bot bench substrate-pallet --pallet=pallet_meta_tx --features=runtime-benchmarks |
@muharem |
bot cancel 2-557b9591-e2d4-4aa7-abf2-e446aed9e642 |
@muharem Command |
bot bench substrate-pallet --pallet=pallet_meta_tx --features=runtime-benchmarks |
@muharem |
bot cancel 3-64ab72b7-dde9-4282-82ea-c58a688d5120 |
@muharem Command |
bot bench substrate-pallet --pallet=pallet_meta_tx --features=runtime-benchmarks |
@muharem https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7814005 was started for your command Comment |
…=dev --target_dir=substrate --features=runtime-benchmarks --pallet=pallet_meta_tx
@muharem Command |
All GitHub workflows were cancelled due to failure one of the required jobs. |
Meta transactions implementation.
The meta transaction follows a layout similar to that of a regular transaction and can leverage the same extensions implementing the
TransactionExtension
trait. Once signed and shared by the signer, the relayer may submit a regular transaction with thepallet_meta_tx::dispatch
call, passing the signed meta transaction as an argument.To see an example, refer to the mock setup and the
sign_and_execute_meta_tx
test case insubstrate/frame/meta-tx/src/tests.rs
file.RFC: #4123