-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pure state sync refactoring (part-2) #6521
Merged
bkchr
merged 14 commits into
paritytech:master
from
liuchengxu:pure-state-sync-refactoring-2
Nov 20, 2024
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
677bd4d
Introduce initial StateSyncMetadata
liuchengxu cae7c88
Move complete into StateSyncMetadata
liuchengxu 40bb9c2
Move imported_bytes into StateSyncMetadata
liuchengxu c598067
Move target_header into StateSyncMetadata
liuchengxu 01340f7
Move skip_proof into StateSyncMetadata
liuchengxu 66f2664
Move target_body and target_justifications into StateSyncMetadata
liuchengxu 6062a2c
Move more functions into StateSyncMetadata
liuchengxu 91144a7
Merge branch 'master' into pure-state-sync-refactoring-2
liuchengxu 05858e0
fmt
liuchengxu 3989de3
Add prdoc
liuchengxu 31031c0
Update substrate/client/network/sync/src/strategy/state_sync.rs
liuchengxu d6104eb
Update substrate/client/network/sync/src/strategy/state_sync.rs
liuchengxu f3ed739
fmt
liuchengxu c7c450c
Merge branch 'master' into pure-state-sync-refactoring-2
bkchr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
title: Pure state sync refactoring (part-2) | ||
|
||
doc: | ||
- audience: Node Dev | ||
description: | | ||
This is the last part of the pure refactoring of state sync, focusing on encapsulating `StateSyncMetadata` as a separate entity. | ||
|
||
crates: | ||
- name: sc-network-sync | ||
bump: none |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit; Would be useful to have some documatation on this struct and exposed methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a private struct and not publicly exposed. Feel free to add some docs if you think that's necessary :(