Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCM V5 - SetHints instruction #6566

Merged
merged 17 commits into from
Dec 9, 2024
Merged

XCM V5 - SetHints instruction #6566

merged 17 commits into from
Dec 9, 2024

Conversation

franciscoaguirre
Copy link
Contributor

Last feature we wanted for V5, changing SetAssetClaimer to be just one of many possible "hints" that you can specify at the beginning of your program to change its behaviour.

This makes it easier to add new hints in the future and have barriers accept them.

@franciscoaguirre franciscoaguirre requested a review from a team as a code owner November 20, 2024 20:37
@franciscoaguirre franciscoaguirre self-assigned this Nov 20, 2024
@franciscoaguirre franciscoaguirre added the T6-XCM This PR/Issue is related to XCM. label Nov 20, 2024
@franciscoaguirre
Copy link
Contributor Author

/cmd fmt

Copy link

Command "fmt" has started 🚀 See logs here

Copy link

Command "fmt" has finished ✅ See logs here

@franciscoaguirre
Copy link
Contributor Author

/cmd fmt

Copy link

Command "fmt" has started 🚀 See logs here

Copy link

Command "fmt" has finished ✅ See logs here

@franciscoaguirre
Copy link
Contributor Author

/cmd fmt

Copy link

github-actions bot commented Dec 4, 2024

Command "fmt" has started 🚀 See logs here

Copy link

github-actions bot commented Dec 4, 2024

Command "fmt" has finished ✅ See logs here

- audience: Runtime Dev
description: |
The new SetHints instruction is a repackaging of SetAssetClaimer that also allows future
"hints" which alter the default behaviour of the executor.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the "hints" and what's the motivation behind it? I am missing the full context of this PR...
Is there an RFC or some documentation for that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RFC 107, I've added it to the prdoc

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12197156653
Failed job name: fmt

@franciscoaguirre
Copy link
Contributor Author

/cmd fmt

Copy link

github-actions bot commented Dec 6, 2024

Command "fmt" has started 🚀 See logs here

Copy link

github-actions bot commented Dec 6, 2024

Command "fmt" has finished ✅ See logs here

@franciscoaguirre franciscoaguirre added this pull request to the merge queue Dec 8, 2024
Merged via the queue into master with commit 906fa9e Dec 9, 2024
197 of 199 checks passed
@franciscoaguirre franciscoaguirre deleted the xcm-hints branch December 9, 2024 00:00
franciscoaguirre added a commit that referenced this pull request Dec 9, 2024
Last feature we wanted for V5, changing `SetAssetClaimer` to be just one
of many possible "hints" that you can specify at the beginning of your
program to change its behaviour.

This makes it easier to add new hints in the future and have barriers
accept them.

---------

Co-authored-by: GitHub Action <action@github.com>
EgorPopelyaev pushed a commit that referenced this pull request Dec 11, 2024
Backporting #6566 to stable2412

Last feature we wanted for V5, changing `SetAssetClaimer` to be just one
of many possible "hints" that you can specify at the beginning of your
program to change its behaviour.

This makes it easier to add new hints in the future and have barriers
accept them.

---------

Co-authored-by: GitHub Action <action@github.com>
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this pull request Jan 4, 2025
Last feature we wanted for V5, changing `SetAssetClaimer` to be just one
of many possible "hints" that you can specify at the beginning of your
program to change its behaviour.

This makes it easier to add new hints in the future and have barriers
accept them.

---------

Co-authored-by: GitHub Action <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants