Error logging for send xcm to pallet-xcm #6579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
added
R0-silent
|
/cmd fmt |
|
Command "fmt" has started 🚀 See logs here |
|
Command "fmt" has finished ✅ See logs here |
bkontur
commented
Nov 21, 2024
acatangiu
approved these changes
Nov 21, 2024
bkontur
added
the
A4-needs-backport
franciscoaguirre
approved these changes
Nov 22, 2024
| @@ -58,7 +58,7 @@ impl< | |||
| let message = Xcm::<Call>::try_from(versioned_message).map_err(|_| { | |||
| log::trace!( | |||
| target: LOG_TARGET, | |||
| "Failed to convert `VersionedXcm` into `XcmV3`.", | |||
| "Failed to convert `VersionedXcm` into `xcm::prelude::Xcm`!", | |||
There was a problem hiding this comment.
Suggested change
| "Failed to convert `VersionedXcm` into `xcm::prelude::Xcm`!", | |
| "Failed to convert `VersionedXcm` into `xcm::latest::Xcm`!", |
There was a problem hiding this comment.
prelude is here better than latest, because imports use use xcm::prelude::*;
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-actions bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
(cherry picked from commit e709c9f)
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 25, 2024
(cherry picked from commit e709c9f)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Nov 27, 2024
EgorPopelyaev
added a commit
that referenced
this pull request
Nov 27, 2024
Backport #6579 into `stable2407` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Egor_P <egor@parity.io>
EgorPopelyaev
added a commit
that referenced
this pull request
Nov 27, 2024
Backport #6579 into `stable2409` from bkontur. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Branislav Kontur <bkontur@gmail.com> Co-authored-by: Egor_P <egor@parity.io>
Krayt78
pushed a commit
to Krayt78/polkadot-sdk
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: