Added fallback_max_weight to Transact for sending messages to V4 chai… #6778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns (#6643) Closes: #6585 Removing the `require_weight_at_most` parameter in V5 Transact had only one problem. Converting a message from V5 to V4 to send to chains that didn't upgrade yet. The conversion would not know what weight to give to the Transact, since V4 and below require it. To fix this, I added back the weight in the form of an `Option<Weight>` called `fallback_max_weight`. This can be set to `None` if you don't intend to deal with a chain that hasn't upgraded yet. If you set it to `Some(_)`, the behaviour is the same. The plan is to totally remove this in V6 since there will be a good conversion path from V6 to V5. --------- Co-authored-by: GitHub Action <action@github.com> Co-authored-by: Adrian Catangiu <adrian@parity.io>
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
bkontur
reviewed
Dec 7, 2024
Co-authored-by: Branislav Kontur <bkontur@gmail.com>
bkontur
previously approved these changes
Dec 9, 2024
x3c41a
reviewed
Dec 9, 2024
x3c41a
previously approved these changes
Dec 9, 2024
| To fix this, XCM v5 Transact now also takes a `fallback_max_weight: Option<Weight>` parameter. | ||
| This can be set to `None` if the instruction is not meant to be sent to chains running XCM versions lower than V5. | ||
| If set to `Some(weight)`, a subsequent conversion to V4 will result in `Transact { require_weight_at_most: weight, .. }`. | ||
| The plan is to remove this workaround in V6 since there will be a good conversion path from V6 to V5. |
There was a problem hiding this comment.
Do we have already have a list of things we want to have in v6? It'd be good to add this one straight away so that we don't forget about it.
x3c41a
previously approved these changes
Dec 9, 2024
bkontur
previously approved these changes
Dec 9, 2024
bkontur
approved these changes
Dec 9, 2024
x3c41a
approved these changes
Dec 9, 2024
acatangiu
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6643 to stable2412.
We need it before the release so we have a good story with chains that haven't upgraded yet.