This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add dispute metrics, some chores (#3842)
* rename: MsgFilter -> MessageInterceptor * feat: add dispute metrics * fixup * test fixins * fix metrics * dummysubsystem export and trait fn fix * chore: fmt * undo unwanted changes * foo * pfmt * fixup * fixup * revert * some more * Update node/malus/Cargo.toml Co-authored-by: Andronik Ordian <write@reusable.software> * Update node/core/dispute-coordinator/src/metrics.rs Co-authored-by: Andronik Ordian <write@reusable.software> * Update node/core/dispute-coordinator/src/metrics.rs Co-authored-by: Andronik Ordian <write@reusable.software> * Update node/core/dispute-coordinator/src/metrics.rs Co-authored-by: Andronik Ordian <write@reusable.software> * add license header * fix lockfile * new with opts * fmt * Update node/core/dispute-coordinator/src/metrics.rs * feature gate Co-authored-by: Andronik Ordian <write@reusable.software>
- Loading branch information
Showing
14 changed files
with
339 additions
and
54 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,99 @@ | ||
// Copyright 2020 Parity Technologies (UK) Ltd. | ||
// This file is part of Polkadot. | ||
|
||
// Polkadot is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Polkadot is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Polkadot. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
use polkadot_node_subsystem_util::metrics::{self, prometheus}; | ||
|
||
#[derive(Clone)] | ||
struct MetricsInner { | ||
/// Number of opened disputes. | ||
open: prometheus::Counter<prometheus::U64>, | ||
/// Votes of all disputes. | ||
votes: prometheus::CounterVec<prometheus::U64>, | ||
/// Conclusion across all disputes. | ||
concluded: prometheus::CounterVec<prometheus::U64>, | ||
} | ||
|
||
/// Candidate validation metrics. | ||
#[derive(Default, Clone)] | ||
pub struct Metrics(Option<MetricsInner>); | ||
|
||
#[cfg(feature = "disputes")] | ||
impl Metrics { | ||
pub(crate) fn on_open(&self) { | ||
if let Some(metrics) = &self.0 { | ||
metrics.open.inc(); | ||
} | ||
} | ||
|
||
pub(crate) fn on_valid_vote(&self) { | ||
if let Some(metrics) = &self.0 { | ||
metrics.votes.with_label_values(&["valid"]).inc(); | ||
} | ||
} | ||
|
||
pub(crate) fn on_invalid_vote(&self) { | ||
if let Some(metrics) = &self.0 { | ||
metrics.votes.with_label_values(&["invalid"]).inc(); | ||
} | ||
} | ||
|
||
pub(crate) fn on_concluded_valid(&self) { | ||
if let Some(metrics) = &self.0 { | ||
metrics.concluded.with_label_values(&["valid"]).inc(); | ||
} | ||
} | ||
|
||
pub(crate) fn on_concluded_invalid(&self) { | ||
if let Some(metrics) = &self.0 { | ||
metrics.concluded.with_label_values(&["invalid"]).inc(); | ||
} | ||
} | ||
} | ||
|
||
impl metrics::Metrics for Metrics { | ||
fn try_register(registry: &prometheus::Registry) -> Result<Self, prometheus::PrometheusError> { | ||
let metrics = MetricsInner { | ||
open: prometheus::register( | ||
prometheus::Counter::with_opts(prometheus::Opts::new( | ||
"parachain_candidate_disputes_total", | ||
"Total number of raised disputes.", | ||
))?, | ||
registry, | ||
)?, | ||
concluded: prometheus::register( | ||
prometheus::CounterVec::new( | ||
prometheus::Opts::new( | ||
"parachain_candidate_dispute_concluded", | ||
"Concluded dispute votes, sorted by candidate is `valid` and `invalid`.", | ||
), | ||
&["validity"], | ||
)?, | ||
registry, | ||
)?, | ||
votes: prometheus::register( | ||
prometheus::CounterVec::new( | ||
prometheus::Opts::new( | ||
"parachain_candidate_dispute_votes", | ||
"Accumulated dispute votes, sorted by candidate is `valid` and `invalid`.", | ||
), | ||
&["validity"], | ||
)?, | ||
registry, | ||
)?, | ||
}; | ||
Ok(Metrics(Some(metrics))) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.