Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update block authoring logic to be compatible with Aura/GRANDPA #37

Closed
rphmeier opened this issue Nov 16, 2018 · 2 comments
Closed

Update block authoring logic to be compatible with Aura/GRANDPA #37

rphmeier opened this issue Nov 16, 2018 · 2 comments
Milestone

Comments

@rphmeier
Copy link
Contributor

We will need to split up the attestation-gathering logic from the Proposer logic.
The Proposer will still look for a minimum number of attested-to parachains, and we will need something for evaluating blocks and making sure they have enough parachain candidates for the time, etc.

Most of the evaluate logic would be placed in an aura::CustomVerifier that checks to see if the authorship cycle has been instantiated for the parent of a block (doing it if not) and then waiting until enough attestations come in before importing the block.

This might lead to some issues around clock synchrony if we don't evaluate blocks for longer than the block time in Aura, but needs further investigation.

Depends on paritytech/substrate#1124

@rphmeier rphmeier added this to the PoC-3 (AFG) milestone Nov 16, 2018
@rphmeier
Copy link
Contributor Author

(this is mostly done in #38)

@rphmeier
Copy link
Contributor Author

rphmeier commented Nov 24, 2018

Remaining tasks (after #42):

tomusdrw pushed a commit that referenced this issue Mar 26, 2021
* Run RustFmt as part of the CI

* Format repo

* Run RustFmt before the default Travis build step

Apparently if you override `script` you also need to make
sure to `build` and `test` the code yourself.

* Format repo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant