-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[CI] Add criticality of release to release notes #1259
Conversation
If we mandate a C label, then I'd suggest a |
Think of the label as something that changes the importance of the user updating in a timely manner - the default importance for the user updating is Low. The importance of a release should never be 'irrelevant' (else why make a release at all). We could also have it so that PRs are by default labelled as low importance, but having it as a manual step causes the author of the PR to think a little about the importance of their PR. |
agree on all points. |
... the priorty, and adds to them the release notes (if it's > low)
There can be some confusing bash in here due to the use of associative arrays, but I'm happy to walk any reviewers through it. In the very near future I hope to re-engineer this script in a more suitable language. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@@ -157,9 +157,7 @@ build-wasm-release: | |||
<<: *compiler_info | |||
# Note: We likely only want to do this for tagged releases, hence the 'only:' | |||
only: | |||
# FIXME remove when ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't forget
Also update some formatting
Devops ticket here: https://github.com/paritytech/devops/issues/569