This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Parachains-runtime #1505
Merged
Parachains-runtime #1505
+1,036
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montekki
added
A3-in_progress
rphmeier
reviewed
Jul 30, 2020
rphmeier
reviewed
Jul 30, 2020
rphmeier
reviewed
Jul 30, 2020
rphmeier
reviewed
Jul 30, 2020
rphmeier
reviewed
Jul 30, 2020
rphmeier
reviewed
Jul 30, 2020
rphmeier
reviewed
Jul 30, 2020
rphmeier
reviewed
Jul 30, 2020
rphmeier
reviewed
Jul 30, 2020
montekki
added
A0-please_review
rphmeier
reviewed
Jul 31, 2020
| use crate::{initializer, inclusion, scheduler, configuration, paras}; | ||
|
|
||
| /// Implementation for the `validators` function of the runtime API. | ||
| pub fn validators<T: initializer::Trait>() -> Vec<ValidatorId> { | ||
| <inclusion::Module<T>>::validators() | ||
| } | ||
|
|
||
| /// Interface to the persistent (stash) identities of the current validators. | ||
| pub struct ValidatorIdentities<T>(sp_std::marker::PhantomData<T>); |
There was a problem hiding this comment.
No, this is used by impl attestations::Trait but since this runtime does not use them, this type is not used in this PR
There was a problem hiding this comment.
it's too late in the evening, now I see what you mean
rphmeier
approved these changes
Jul 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some initial code.
Closes #1209