This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion PR for #7039: grandpa-rpc dont share subscription manager, only executor #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
added
A0-please_review
|
Waiting for commit status. |
|
Head SHA changed; merge aborted. |
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit 
ordian
added a commit
that referenced
this pull request
Sep 14, 2020
* master: Companion PR for #6984 (#1661) Update some dependencies. (#1718) Add a specific memory requirements (#1716) Companion PR for #7039: grandpa-rpc dont share subscription manager, only executor (#1687) Update bytes. (#1715) Add a note about memory requirements (#1714) Update parity-multiaddr. (#1700) typo in proxy tests (#1713) Companion PR for ` Add a `build-sync-spec` subcommand and remove the CHT roots from the light sync state.` (#1670) Forwardport: Validation: don't detect STDIN closing when running in process (#1695) (#1703)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PR for #7039.
Don't share subscription manager with grandpa-rpc, it is enough to only share the executor.