This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add CI job to verify extrinsic ordering #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s3krit
added
A0-please_review
s3krit
requested review from
andresilva,
General-Beck,
shawntabrizi,
gabreal,
apopiak and
TriplEight
TriplEight
reviewed
Nov 13, 2020
| ) | ||
|
|
||
| if [ -n "$changed_extrinsics" ]; then | ||
| echo "[!] Extrinsics indexing/ordering has changed in the ${RUNTIME} runtime! If this change is intentional, please bump transaction_version in lib.rs. Changed extrinsics:" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?: This PR adds a job that uses @jacogr 's
polkadot-js-metadata-cmptool to verify that if the ordering/indexing of the extrinsics of a runtime have changed since the last release,transaction_versionfor that runtime has been bumped.How?: We grab the polkadot binary produced in the
test-linux-stablejob, and for each runtime, we run the client in the background with--chain=$RUNTIME-local. Then we usepolkadot-js-metadata-cmpto compare the metadata with the live chain.This essentially automates this check that is completed as part of our release process - but on a per-PR basis. In design and implementation it's somewhat similar to our
check_runtime.shCI job.After merging, we should add this check as a must-pass to our branch protection rules for
masterAn example of a passing job can be found here
An example of a failing job can be found here (to cause it to fail, I had it compare the metadata between kusama and polkadot)