This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Integrate Approval Voting into Overseer / Service / GRANDPA #2412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-please_review
rphmeier
force-pushed
the
rh-approval-voting-integration
branch
from
3fa588a to
7d17288
Compare
eskimor
approved these changes
Feb 15, 2021
ordian
added a commit
that referenced
this pull request
Feb 17, 2021
…ing-work-on-a-small-testnet * ao-fix-approval-import-tests: fix expected ancestry in tests fix ordering in determine_new_blocks fix infinite loop in determine_new_blocks fix test assertion fix panic in cache_session_info_for_head tests: use future::join Clean up sizes for a workspace (#2445) Integrate Approval Voting into Overseer / Service / GRANDPA (#2412) Mitigation of SIGBUS (#2440) node: migrate grandpa voting rule to async api (#2422) Initializer + Paras Clean Up Messages When Offboarding (#2413) Polkadot companion for 8114 (#2437) Companion for substrate#8079 (#2408) Bump if-watch to `0.1.8` to fix panic (#2436) Notify collators about seconded collation (#2430) CancelProxy uses `reject_announcement` instead of `remove_announcement` (#2429) Rococo genesis 1337 (#2425)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2321
This integrates the approval voting subsystem into the overseer and the service.
It doesn't fully integrate approval checking into the finality process, which is the end goal, but instead we impose an artificial lag on finality and produce a metric indicating where approval checking would vote to finalize.