Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for substrate#9115 #3265

Merged
18 commits merged into from
Sep 14, 2021
Merged

Companion for substrate#9115 #3265

18 commits merged into from
Sep 14, 2021

Conversation

koushiro
Copy link
Contributor

Companion for paritytech/substrate#9115

migrate the Council and TechnicalCommittee storage prefix:

Instance1Collective ==> Council
Instance2Collective ==> TechnicalCommittee

@koushiro
runtime(kusama/polkadot): migrations for collective storage prefix
2aa1953 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro koushiro mentioned this pull request Jun 16, 2021
Merged
@koushiro koushiro marked this pull request as ready for review June 16, 2021 10:52
gui1117
gui1117 approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@gui1117 gui1117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, I tested the migration with try-runtime on polkadot block 6,163,183

@gui1117 gui1117 added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Jul 30, 2021
@koushiro
Copy link
Contributor Author

looks good to me, I tested the migration with try-runtime on polkadot block 6,163,183

I want to learn about the try-runtime tool. Is there a corresponding tutorial or document?

gui1117
gui1117 suggested changes Aug 2, 2021
View reviewed changes
runtime/kusama/src/lib.rs Outdated Show resolved Hide resolved
@gui1117
Copy link
Contributor

gui1117 commented Aug 2, 2021

looks good to me, I tested the migration with try-runtime on polkadot block 6,163,183

I want to learn about the try-runtime tool. Is there a corresponding tutorial or document?

there is this seminar https://www.crowdcast.io/e/substrate-seminar/41
and this doc https://substrate.dev/docs/en/knowledgebase/advanced/try-runtime
most important is to compile with try-runtime and then use the subcommand associated

kianenigma
kianenigma approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that migration is tested.

@gui1117 gui1117 added A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. labels Sep 10, 2021
@koushiro
Fix
4784900 
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@gui1117
Copy link
Contributor

gui1117 commented Sep 10, 2021 •
edited
Loading

I ran a successful migration with try-runtime with on current kusama and polkadot

@ghost
Copy link

ghost commented Sep 14, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 14, 2021

Merge aborted: Checks failed for 061769d

@gui1117
Copy link
Contributor

gui1117 commented Sep 14, 2021

bot merge

@ghost
Copy link

ghost commented Sep 14, 2021

Merge aborted: Checks failed for 061769d

@gui1117
Copy link
Contributor

gui1117 commented Sep 14, 2021

bot merge

@ghost
Copy link

ghost commented Sep 14, 2021

Waiting for commit status.

@ghost ghost merged commit 560e965 into paritytech:master Sep 14, 2021
@koushiro koushiro deleted the migrate-pallet-collective branch September 14, 2021 14:01
@xlc xlc mentioned this pull request Sep 14, 2021
Closed
5 tasks
ordian added a commit that referenced this pull request Sep 15, 2021
@ordian
Merge branch 'master' into rh-approval-wakeups-update
664573c 
* master: (21 commits)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
  dockerfiles: upgrade to ubuntu:20.04; some chore (#3828)
  make polkadot-runtime optional feature (#3820)
  Companion for #9648 (#3757)
  Substrate Companion #9737 (#3830)
  Add logging for worker spawn failures (#3827)
  Add Canvas (#3823)
  Allow staking miner to use different election algorithms (#3752)
  Do not expire HRMP open channel requests (#3543)
  Bump tokio from 1.10.1 to 1.11.0 (#3821)
  Add words to the dictionnary (#3819)
  Add vault secrets to puplish-rustdoc job (#3816)
  ...
ordian added a commit that referenced this pull request Sep 16, 2021
@ordian
Merge branch 'master' into temporary-malus
c81f175 
* master:
  Raised nits on #3813 (#3844)
  Don't try to connect to ourselves. (#3855)
  add dispute metrics, some chores (#3842)
  add type info derive to senderror (#3860)
  Companion for #8615: enrich metadata with type information (#3336)
  approval-voting: processed wakeups can also update approval state (#3848)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
ordian added a commit that referenced this pull request Sep 17, 2021
@ordian
Merge branch 'master' into bernhard-malus-fx
93c6d06 
* master:
  Raised nits on #3813 (#3844)
  Don't try to connect to ourselves. (#3855)
  add dispute metrics, some chores (#3842)
  add type info derive to senderror (#3860)
  Companion for #8615: enrich metadata with type information (#3336)
  approval-voting: processed wakeups can also update approval state (#3848)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
@github-actions github-actions bot mentioned this pull request Oct 11, 2021
Closed
@AurevoirXavier AurevoirXavier mentioned this pull request Mar 22, 2022
Closed
17 tasks
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@kianenigma kianenigma kianenigma approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koushiro @gui1117 @shawntabrizi @kianenigma