Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

overseer gen minor #3479

Merged
merged 2 commits into from
Jul 15, 2021
Merged

overseer gen minor #3479

merged 2 commits into from
Jul 15, 2021

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Jul 15, 2021

Minor adjustments, mostly missing #support_crate :: prefixes which became apparent when refactoring again in a larger scope

@drahnr drahnr added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. I4-annoyance Code behaves within expectations, however this “expected behaviour” itself is at issue. I8-refactor Code needs refactoring. and removed I4-annoyance Code behaves within expectations, however this “expected behaviour” itself is at issue. labels Jul 15, 2021
@drahnr drahnr requested a review from ordian July 15, 2021 14:17
ordian
ordian approved these changes Jul 15, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it compiles it works 🤷

@drahnr
Copy link
Contributor Author

drahnr commented Jul 15, 2021 •
edited
Loading

if it compiles it works shrug

True, but with #3454 this caused some PITA again 😅

@drahnr drahnr merged commit 2c8a2b5 into master Jul 15, 2021
@drahnr drahnr deleted the bernhard-overseer-gen-minor branch July 15, 2021 14:51
ordian added a commit that referenced this pull request Jul 20, 2021
@ordian
Merge branch 'master' into ao-enable-disputes
74f0319 
* master:
  Update secp256k1 and remove unrequired usage (#3502)
  Bump libc from 0.2.91 to 0.2.98 (#3496)
  Bump slotmap from 1.0.2 to 1.0.5 (#3495)
  Gossip rebroadcast rate limiter (#3494)
  dependabot: ignore another git dep (#3493)
  add rustfmt toml (#3491)
  Disputes runtime (#2947)
  Bump async-process from 1.0.1 to 1.1.0 (#3122)
  remove the kubernetes helm chart (#3483)
  added pallet-proxy in rococo feature dependencies (#3486)
  Update BEEFY+MMR integration. (#3480)
  more verbose asserts (#3476)
  ci: use srtool-actions to build runtimes (#3423)
  overseer gen minor chore fixes (#3479)
@github-actions github-actions bot mentioned this pull request Aug 24, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. I8-refactor Code needs refactoring.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drahnr @ordian