This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
XCM Account Derivation #3505
Closed
XCM Account Derivation #3505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related to #3500 |
apopiak
added
A0-please_review
gavofyork
suggested changes
Jul 20, 2021
| X2(Parachain(para_id), AccountId32 { id, network }) | ||
| if network == NetworkId::Any || &network == &Network::get() => | ||
| { | ||
| (para_id, id).using_encoded(blake2_256) |
There was a problem hiding this comment.
Should have a disambiguating prefix.
There was a problem hiding this comment.
Like generate a 28byte array and prepend a u32 with the para id?
|
Will not likely be actually used in practice. Might revisit if parachains want to enable this kind of pattern. |
louismerlin
removed
the
D5-nicetohaveaudit ⚠️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a struct to derive a local account id from a parachain + account combination and adds it to Kusama, Rococo and Westend.