Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Integrate the claims module #355

Merged
merged 8 commits into from
Aug 7, 2019
Merged

Integrate the claims module #355

merged 8 commits into from
Aug 7, 2019

Conversation

gavofyork
Copy link
Member

No description provided.

@gavofyork
Copy link
Member Author

CC @jacogr

Co-Authored-By: thiolliere <gui.thiolliere@gmail.com>
@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Aug 7, 2019
@jacogr
Copy link
Contributor

jacogr commented Aug 7, 2019

The metadata fights against this a bit atm, for this -

decl_event!(
	pub enum Event<T> where
		B = BalanceOf<T>,
		A = <T as system::Trait>::AccountId
	{
		/// Someone claimed some DOTs.
		Claimed(A, EthereumAddress, B),
	}
);

It returns types "A" and "B" (which really, could be anything) in the metadata. We don't get A = AccountId, raher only A. It would be better doing (based on the current limitations),

decl_event!(
	pub enum Event<T> where
		BalanceOf = BalanceOf<T>,
		AccountId = <T as system::Trait>::AccountId
	{
		/// Someone claimed some DOTs.
		Claimed(AccountId, EthereumAddress, BalanceOf),
	}
);

@gavofyork
Copy link
Member Author

@jacogr make a PR?

@gavofyork
Copy link
Member Author

nm already fixed.

@gavofyork gavofyork added A8-looksgood and removed A0-please_review Pull request needs code review. labels Aug 7, 2019
@bkchr bkchr merged commit 7c6390f into master Aug 7, 2019
@bkchr bkchr deleted the gav-int-claims branch August 7, 2019 21:49
tomusdrw added a commit that referenced this pull request Mar 26, 2021
* call dispatch origin

* Update modules/call-dispatch/src/lib.rs

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>

* cargo fmt --all

Co-authored-by: Tomasz Drwięga <tomusdrw@users.noreply.github.com>
imstar15 pushed a commit to imstar15/polkadot that referenced this pull request Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants