This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add XCM Benchmarks to Kusama #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/benchmark xcm kusama pallet_xcm_benchmarks::generic |
|
Benchmark Kusama XCM for branch "shawntabrizi-kusama-xcm-benchmarks" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs ResultsERROR: Unable to commit file ./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs |
|
/benchmark xcm kusama pallet_xcm_benchmarks::generic |
|
Benchmark Kusama XCM for branch "shawntabrizi-kusama-xcm-benchmarks" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs Results |
…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::generic --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_generic.rs
|
/benchmark xcm kusama pallet_xcm_benchmarks::fungible |
|
Benchmark Kusama XCM for branch "shawntabrizi-kusama-xcm-benchmarks" with command cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs Results |
…k --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs
shawntabrizi
added
B7-runtimenoteworthy
C1-low
|
/benchmark xcm kusama pallet_xcm_benchmarks::generic |
|
/benchmark xcm kusama pallet_xcm_benchmarks::fungible |
|
Benchmark Kusama XCM for branch "shawntabrizi-kusama-xcm-benchmarks" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs Toolchain: stable-x86_64-unknown-linux-gnu (default) ResultsERROR: Unable to commit file ./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs |
|
/benchmark xcm kusama pallet_xcm_benchmarks::fungible |
|
Benchmark Kusama XCM for branch "shawntabrizi-kusama-xcm-benchmarks" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs Toolchain: stable-x86_64-unknown-linux-gnu (default) Results |
added 2 commits
March 8, 2022 09:58
…shawntabrizi-kusama-xcm-benchmarks
…-- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=pallet_xcm_benchmarks::fungible --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --template=./xcm/pallet-xcm-benchmarks/template.hbs --output=./runtime/kusama/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs
KiChjang
reviewed
Mar 9, 2022
| // --execution=wasm | ||
| // --wasm-execution=compiled | ||
| // --heap-pages=4096 | ||
| // --header=./file_header.txt |
There was a problem hiding this comment.
Where does benchbot get this file? I thought it was from the top-level file_header.txt file, but I've already modified it to have the current year in the license, yet this autogenerated file STILL says 2021. What gives?
There was a problem hiding this comment.
it is def the top level file header
KiChjang
approved these changes
Mar 9, 2022
|
I also approve this PR |
kianenigma
reviewed
Mar 17, 2022
| // Storage: XcmPallet SupportedVersion (r:1 w:0) | ||
| // Storage: XcmPallet VersionDiscoveryQueue (r:1 w:1) | ||
| // Storage: XcmPallet SafeXcmVersion (r:1 w:0) | ||
| // Storage: Configuration ActiveConfig (r:1 w:0) |
There was a problem hiding this comment.
I think this storage item should be whitelisted since it is read in all blocks afaik.
kianenigma
approved these changes
Mar 17, 2022
|
Oh wow, since this touches a runtime directory, we'll need an additional approval, either from @bkchr or @gavofyork (or @rphmeier if he's ok with reviewing this). |
|
bot merge |
|
Error: Checks failed for 00d77ff |
rphmeier
approved these changes
Apr 13, 2022
bkchr
approved these changes
Apr 14, 2022
10 tasks
louismerlin
added
D1-audited 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's not merge this until we have deployed it to Westend for a bit.