This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
Pull request is in progress. No review needed at this stage.
label
Dec 2, 2021
@chevdor is this ready? |
chevdor
commented
Dec 2, 2021
Comment on lines
45
to
+49
impl<T: frame_system::Config> pallet_utility::WeightInfo for WeightInfo<T> { | ||
fn batch(c: u32) -> Weight { | ||
(13_489_000 as Weight) | ||
// Standard Error: 0 | ||
.saturating_add((605_000 as Weight).saturating_mul(c as Weight)) | ||
fn batch(c: u32, ) -> Weight { | ||
(16_110_000 as Weight) | ||
// Standard Error: 2_000 | ||
.saturating_add((6_325_000 as Weight).saturating_mul(c as Weight)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10x increase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file wasn't updated since 1 year.
Here we have similar results: https://github.com/paritytech/polkadot/pull/4113/files#diff-877433e4f55fc21b56c123e9858f101eda2bed860ddec10d6bdbecf9510ff812R50
github-actions
bot
added
A0-please_review
Pull request needs code review.
and removed
A3-in_progress
Pull request is in progress. No review needed at this stage.
labels
Dec 2, 2021
chevdor
added
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
A3-in_progress
Pull request is in progress. No review needed at this stage.
B7-runtimenoteworthy
C1-low
PR touches the given topic and has a low impact on builders.
D2-notlive 💤
PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
and removed
D2-notlive 💤
PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
labels
Dec 2, 2021
@bkchr ready yes |
bkchr
added a commit
that referenced
this pull request
Dec 2, 2021
* Update Substrate branch * add disputes to Kusama runtime (#4356) * add disputes to Kusama runtime * Update DisputesHandler * fmt * add the benchmarks * cargo run --quiet --release --features=runtime-benchmarks -- benchmark --chain=kusama-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/kusama/src/weights/runtime_parachains_disputes.rs Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Parity Bot <admin@parity.io> * Add XCM pallet and config to Polkadot runtime (#4313) * xcm added * xcm pallet & config added Polkadot * set advertise XCM version to 2 for Polkadot * remove ChildSystemParachainAsSuperuser from Polkadot XCM config * remove unpaid execution for system parachains * remove unused imports Co-authored-by: Alexander Popiak <alexander.popiak@parity.io> * Pin changelogerator to the latest compatible version for the current flow (#4392) (#4436) * add missing feature (#4355) * add pallet-babe/std (#4438) * Apply v0.9.13 weights (#4444) * Update weights for Westend * Update weights for kusama * Update weights for polkadot * bump tx versions (#4447) (#4450) Co-authored-by: Robert Habermeier <rphmeier@gmail.com> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Parity Bot <admin@parity.io> Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com> Co-authored-by: Alexander Popiak <alexander.popiak@parity.io> Co-authored-by: Chevdor <chevdor@users.noreply.github.com> Co-authored-by: Xiliang Chen <xlchen1291@gmail.com> Co-authored-by: zjb0807 <zjb0807@qq.com> Co-authored-by: Martin Pugh <martin@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
A2-insubstantial
Pull request requires no code review (e.g., a sub-repository hash update).
A3-in_progress
Pull request is in progress. No review needed at this stage.
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.