Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Versi chainspec based on Rococo. #4485

Merged
merged 9 commits into from
Dec 16, 2021
Merged

Versi chainspec based on Rococo. #4485

merged 9 commits into from
Dec 16, 2021

Conversation

eskimor
Copy link
Member

@eskimor eskimor commented Dec 7, 2021

Fixes #4481

@eskimor eskimor added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Dec 7, 2021
@PierreBesson
Copy link
Contributor

@eskimor can you regenerate the Versi json chainspec. As it currently is just a copy-paste of the rococo one.

drahnr
drahnr reviewed Dec 13, 2021
View reviewed changes
cli/src/command.rs Outdated
@@ -167,6 +171,7 @@ impl SubstrateCli for Cli {
}

fn native_runtime_version(spec: &Box<dyn service::ChainSpec>) -> &'static RuntimeVersion {
dbg!(spec.id());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray leftover?

drahnr
drahnr approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@drahnr drahnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One stray dbg!(_), other than that LGTM

bkchr
bkchr reviewed Dec 13, 2021
View reviewed changes
cli/src/command.rs Outdated Show resolved Hide resolved
@drahnr
Copy link
Contributor

drahnr commented Dec 16, 2021

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 73d7aa5 into master Dec 16, 2021
@paritytech-processbot paritytech-processbot bot deleted the rk-versi branch December 16, 2021 10:47
@drahnr drahnr mentioned this pull request Dec 16, 2021
Merged
ordian added a commit that referenced this pull request Dec 16, 2021
@ordian
Merge branch 'master' into pep-primitives-constants-notice
68dc2a2 
* master:
  Bump tokio from 1.14.0 to 1.15.0 (#4537)
  Bump mick-jaeger from 0.1.6 to 0.1.7 (#4538)
  Versi chainspec based on Rococo. (#4485)
  Bump proc-macro2 from 1.0.33 to 1.0.34 (#4526)
  fix compile with new compiler - dead code (#4530)
  introduce trusted parachain Encointer for rococo and westend (#4213)
  add Encointer TrustedTeleporter (#4401)
  Bump libc from 0.2.109 to 0.2.112 (#4522)
  Bump serde_json from 1.0.72 to 1.0.73 (#4523)
drahnr pushed a commit that referenced this pull request Dec 20, 2021
@eskimor @bkchr @drahnr
Versi chainspec based on Rococo. (#4485)
64900ef 
* Versi chainspec based on Rococo.

* Fix.

* Fix compilation without features.

* Spelling

* Another typo.

* Support versi in native version

* 🤦

* Regenerated genesis for versi.

* Update cli/src/command.rs

Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
drahnr pushed a commit that referenced this pull request Dec 20, 2021
@eskimor @bkchr @drahnr
Versi chainspec based on Rococo. (#4485)
5ed332f 
* Versi chainspec based on Rococo.

* Fix.

* Fix compilation without features.

* Spelling

* Another typo.

* Support versi in native version

* 🤦

* Regenerated genesis for versi.

* Update cli/src/command.rs

Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
drahnr pushed a commit that referenced this pull request Dec 20, 2021
@eskimor @bkchr @drahnr
Versi chainspec based on Rococo. (#4485)
d8b71a1 
* Versi chainspec based on Rococo.

* Fix.

* Fix compilation without features.

* Spelling

* Another typo.

* Support versi in native version

* 🤦

* Regenerated genesis for versi.

* Update cli/src/command.rs

Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
drahnr pushed a commit that referenced this pull request Dec 20, 2021
@eskimor @bkchr @drahnr
Versi chainspec based on Rococo. (#4485)
17f9deb 
* Versi chainspec based on Rococo.

* Fix.

* Fix compilation without features.

* Spelling

* Another typo.

* Support versi in native version

* 🤦

* Regenerated genesis for versi.

* Update cli/src/command.rs

Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
drahnr pushed a commit that referenced this pull request Dec 20, 2021
@eskimor @bkchr @drahnr
Versi chainspec based on Rococo. (#4485)
66fceb7 
* Versi chainspec based on Rococo.

* Fix.

* Fix compilation without features.

* Spelling

* Another typo.

* Support versi in native version

* 🤦

* Regenerated genesis for versi.

* Update cli/src/command.rs

Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@drahnr drahnr drahnr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup versi chain in Polkadot repo
4 participants
@eskimor @PierreBesson @drahnr @bkchr