Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

runtime/westend: add disputes #5046

Merged
merged 3 commits into from
Mar 7, 2022
Merged

runtime/westend: add disputes #5046

merged 3 commits into from
Mar 7, 2022

Conversation

ordian
Copy link
Member

@ordian ordian commented Mar 7, 2022

Follow-up to #4993.

@ordian ordian added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Mar 7, 2022
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Mar 7, 2022
@ordian
Copy link
Member Author

ordian commented Mar 7, 2022

/benchmark runtime westend parachains_disputes

@parity-benchapp
Copy link

parity-benchapp bot commented Mar 7, 2022 •
edited
Loading

Benchmark Runtime Westend Pallet for branch "ao-disputes-westend" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=parachains_disputes --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.57.0 (f1edd0429 2021-11-29)

Results 
2022-03-07 16:45:18 [0] 💸 generated 1 npos voters, 1 from validators and 0 nominators    
2022-03-07 16:45:18 Took active validators from set with wrong size    
2022-03-07 16:45:18 Took active validators from set with wrong size.    
2022-03-07 16:45:18 Took active validators from set with wrong size    
Error: 
   0: �[91mInvalid input: No benchmarks found which match your input.�[0m

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

ERROR: Unable to commit file ./runtime/westend/src/weights/

@ordian ordian requested a review from rphmeier March 7, 2022 16:06
@ordian ordian force-pushed the ao-disputes-westend branch from f182c8b to 5271f67 Compare March 7, 2022 16:07
@ordian
Copy link
Member Author

ordian commented Mar 7, 2022

/benchmark runtime westend runtime_parachains::disputes

rphmeier
rphmeier reviewed Mar 7, 2022
View reviewed changes
runtime/westend/src/lib.rs
@@ -828,7 +828,7 @@ impl parachains_session_info::Config for Runtime {}

impl parachains_inclusion::Config for Runtime {
type Event = Event;
type DisputesHandler = ();
type DisputesHandler = ParasDisputes;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@parity-benchapp
Copy link

parity-benchapp bot commented Mar 7, 2022 •
edited
Loading

Benchmark Runtime Polkadot Pallet for branch "ao-disputes-westend" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_disputes.rs

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.57.0 (f1edd0429 2021-11-29)

Results 
Pallet: "runtime_parachains::disputes", Extrinsic: "force_unfreeze", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: ParasDisputes Frozen (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=      0.8
              µs

Reads = 0
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=      0.8
              µs

Reads = 0
Writes = 1

cargo run --quiet --profile=production --features=runtime-benchmarks …
63314fd 
…-- benchmark --chain=polkadot-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/polkadot/src/weights/runtime_parachains_disputes.rs
@parity-benchapp
Copy link

parity-benchapp bot commented Mar 7, 2022 •
edited
Loading

Benchmark Runtime Westend Pallet for branch "ao-disputes-westend" with command cargo run --quiet --profile=production --features=runtime-benchmarks -- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_disputes.rs

Toolchain: stable-x86_64-unknown-linux-gnu (default)
rustc 1.57.0 (f1edd0429 2021-11-29)

Results 
Pallet: "runtime_parachains::disputes", Extrinsic: "force_unfreeze", Lowest values: [], Highest values: [], Steps: 50, Repeat: 20
Raw Storage Info
========
Storage: ParasDisputes Frozen (r:0 w:1)

Median Slopes Analysis
========
-- Extrinsic Time --

Model:
Time ~=    0.829
              µs

Reads = 0
Writes = 1

Min Squares Analysis
========
-- Extrinsic Time --

Model:
Time ~=    0.829
              µs

Reads = 0
Writes = 1

cargo run --quiet --profile=production --features=runtime-benchmarks …
7376cd8 
…-- benchmark --chain=westend-dev --steps=50 --repeat=20 --pallet=runtime_parachains::disputes --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --header=./file_header.txt --output=./runtime/westend/src/weights/runtime_parachains_disputes.rs
@ordian
Copy link
Member Author

ordian commented Mar 7, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit d3644f3 into master Mar 7, 2022
@paritytech-processbot paritytech-processbot bot deleted the ao-disputes-westend branch March 7, 2022 19:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rphmeier rphmeier rphmeier approved these changes

@drahnr drahnr drahnr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ordian @drahnr @rphmeier