This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Chain-selection subsystem data revert #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
davxy
added
B0-silent
skunert
reviewed
Apr 20, 2022
github-actions
bot
added
A0-please_review
skunert
reviewed
Apr 22, 2022
drahnr
reviewed
Apr 22, 2022
drahnr
reviewed
Apr 22, 2022
drahnr
reviewed
Apr 22, 2022
drahnr
reviewed
Apr 22, 2022
drahnr
suggested changes
Apr 22, 2022
4 tasks
I already started working on the "approval-voting" subsystem revert, but before opening a PR for that, this needs to be merged since some code is shared. If it is not a problem, I prefer to keep the PRs for the subtasks separated in order to simplify the review. |
drahnr
approved these changes
Apr 26, 2022
skunert
reviewed
Apr 27, 2022
skunert
approved these changes
Apr 27, 2022
|
Looks good to me, greenlit from my side. I prefer smaller reviewable PRs, so very much in favor of splitting the work into concise chunks as you do 👍 |
Co-authored-by: Sebastian Kunert <skunert49@gmail.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #5396
This PR introduces the revert of some of the data related to parachains management.
In particular, this addresses revert of chain-selection subsystem.
More work should be done to revert approval voting information, this will be addressed by a separate PR.