Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update weights #5601

Merged
merged 4 commits into from
May 30, 2022
Merged

update weights #5601

merged 4 commits into from
May 30, 2022

Conversation

coderobe
Copy link
Contributor

this PR will also be backported to the current release branch once reviewed & merged

@coderobe coderobe added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels May 27, 2022
@github-actions github-actions bot added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels May 27, 2022
@coderobe coderobe marked this pull request as ready for review May 27, 2022 07:52
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels May 27, 2022
@coderobe coderobe mentioned this pull request May 27, 2022
Closed
18 tasks
@ggwpez
Copy link
Member

ggwpez commented May 27, 2022

Looks like only a few extrinsics changed on swc. Some random samples should still be checked manually to see if there are bugs in swc.
I would consider every change <1µs as insignificant, since the ExtrinsicBaseWeight is about 80µs.

The only one that really asymptotically increased is the get_npos_voters.
image
Issue paritytech/substrate#11397 will then give exact numbers for the asymptotic behaviour, but in this case its correct since s has a maximum of 100 in the staking benchmarks.

EgorPopelyaev
EgorPopelyaev reviewed May 30, 2022
View reviewed changes
runtime/kusama/src/weights/pallet_elections_phragmen.rs
// Standard Error: 40_000
.saturating_add((240_000 as Weight).saturating_mul(d as Weight))
.saturating_add((48_208_000 as Weight).saturating_mul(v as Weight))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big jump up of weight value

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The git diff is a bit confusing here, but parameter v is nearly the same as before.
Paramete d got kicked out. This is only a very small increase.

EgorPopelyaev
EgorPopelyaev reviewed May 30, 2022
View reviewed changes
runtime/polkadot/src/weights/pallet_utility.rs
(4_943_000 as Weight)
// Standard Error: 2_000
.saturating_add((3_798_000 as Weight).saturating_mul(c as Weight))
(11_289_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

≈x2 jump

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constant component does not really matter here compared to the component c.
c goes up to 1000 for this benchmark. SWC will soon take the correct slope maxima into account to simplify these comparisions.

@coderobe coderobe merged commit 2c28577 into master May 30, 2022
@coderobe coderobe deleted the coderobe/weights-next branch May 30, 2022 10:41
coderobe added a commit that referenced this pull request May 30, 2022
@coderobe
update weights (#5601)
f409cf2 
* polkadot: update weights

* kusama: update weights

* westend: update weights

* rococo: update weights
coderobe added a commit that referenced this pull request May 30, 2022
@coderobe
update weights (#5601) (#5609)
a7e188c 
* polkadot: update weights

* kusama: update weights

* westend: update weights

* rococo: update weights
al3mart pushed a commit that referenced this pull request Jul 14, 2022
@coderobe
update weights (#5601)
94e3608 
* polkadot: update weights

* kusama: update weights

* westend: update weights

* rococo: update weights
@librelois librelois mentioned this pull request Jul 19, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@chevdor chevdor Awaiting requested review from chevdor

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coderobe @ggwpez @EgorPopelyaev