This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Changed Bonding & SlashDefer Duration in Westend #5634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepetrowski
added
B7-runtimenoteworthy
C1-low
joepetrowski
approved these changes
Jun 3, 2022
coderobe
approved these changes
Jun 7, 2022
|
bot merge |
paritytech-processbot
bot
deleted the
domi/change-westend-bonding-duration
branch
al3mart
pushed a commit
that referenced
this pull request
Jul 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kindly suggesting to reduce the
Bonding Duration(and hence also theSlashDefer Durationslightly less) in Westend so that teams can execute their tests faster.The new proposed time frames are the following :
Why 12 and 6 (or 2 and 1) ?
The specific values are suggested since I realised (from testing locally and trying out different bonding values) that I could not insert anything less than a whole era (6h in westend) or positive integer multiples of an era. So based on this assumption, the shortest time frame for Bonding Duration would be 2 eras since SlashDefer needs to be slightly less so 1 era. Please do correct me if I am wrong but I think this is related to the fact that these constants are of type
EraIndexwhich is au32.