This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Governance 2 (Part 1, Non-Controversial Changes) #5892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shawntabrizi
added
B0-silent
shawntabrizi
commented
Aug 16, 2022
Comment on lines
+1
to
+4
| // Copyright 2022 Parity Technologies (UK) Ltd. | ||
| // This file is part of Polkadot. | ||
|
|
||
| // Polkadot is free software: you can redistribute it and/or modify |
There was a problem hiding this comment.
This file is exactly copy and paste from the existing runtime configuration.
ggwpez
approved these changes
Aug 16, 2022
bkchr
approved these changes
Aug 16, 2022
| @@ -253,8 +253,8 @@ where | |||
| } | |||
|
|
|||
| #[cfg(feature = "runtime-benchmarks")] | |||
| fn successful_origin() -> Origin { | |||
| Origin::root() | |||
| fn try_successful_origin() -> Result<Origin, ()> { | |||
There was a problem hiding this comment.
| } | ||
|
|
||
| for i in 0 .. max_people { | ||
| let leaser = account("lease_deposit", i, 0); | ||
| assert_eq!(T::Currency::reserved_balance(&leaser), T::Currency::minimum_balance()); | ||
| } | ||
|
|
||
| }: _(RawOrigin::Root, para) | ||
| let origin = T::ForceOrigin::successful_origin(); |
There was a problem hiding this comment.
There is try_successful_origin and successful_origin, which is automatically implemented as try_successful_origin().unwrap().
In this case, we need the successful origin
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
kianenigma
approved these changes
Aug 16, 2022
|
bot merge |
ordian
added a commit
that referenced
this pull request
Aug 29, 2022
* master: (23 commits) Bump futures-util from 0.3.21 to 0.3.23 (#5922) Companion for 12095 (#5924) use generated preimage weight (#5904) Update Substrate to make companion check happy (#5934) Fix wrong logic. (#5931) update weights (#5911) Clean up MigrateToV10 (#5921) Bump async-trait from 0.1.56 to 0.1.57 (#5919) Send back empty votes + log in approval-voting in case candidate entry is missing. (#5925) chore: bump zombienet version (#5914) Bump indexmap from 1.9.0 to 1.9.1 (#5918) Bump proc-macro2 from 1.0.40 to 1.0.43 (#5878) Bump hyper from 0.14.19 to 0.14.20 (#5901) Fix output file for updating weights in run_benches_for_runtime.sh (#5906) Companion to Substrate PR 12006 (#5913) pin gha versions (#5916) Companion for new Trie cache (#5897) [ci] Add check-runtime-migration job (#5891) Governance 2 (Part 1, Non-Controversial Changes) (#5892) Added Dwellir bootnodes for Kusama and Polkadot (#5772) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking apart some of the changes from: #5205
These should be all non-controversial changes, and refactors the exact governance changes from master, making it easier to audit the changes from the #5205.