Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update weights #5910

Merged
merged 4 commits into from
Aug 23, 2022
Merged

update weights #5910

merged 4 commits into from
Aug 23, 2022

Conversation

coderobe
Copy link
Contributor

🏋️‍♀️

@coderobe coderobe added A0-please_review Pull request needs code review. B7-runtimenoteworthy C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 22, 2022
This was referenced Aug 22, 2022
@@ -139,16 +139,14 @@ impl<T: frame_system::Config> pallet_election_provider_multi_phase::WeightInfo f
/// The range of component `t` is `[500, 1000]`.
/// The range of component `a` is `[500, 800]`.
/// The range of component `d` is `[200, 400]`.
fn submit_unsigned(v: u32, t: u32, a: u32, d: u32, ) -> Weight {
(0 as Weight)
fn submit_unsigned(v: u32, _t: u32, a: u32, d: u32, ) -> Weight {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big jump from 0 to 196_420_000

.saturating_add((909_000 as Weight).saturating_mul(a as Weight))
// Standard Error: 13_000
.saturating_add((160_000 as Weight).saturating_mul(d as Weight))
(113_324_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10x jump of the weight from 14_945_000 to 113_324_000

.saturating_add(T::DbWeight::get().reads(4 as Weight))
.saturating_add(T::DbWeight::get().writes(4 as Weight))
}
// Storage: Skipped Metadata (r:0 w:0)
/// The range of component `k` is `[0, 500]`.
fn refund(k: u32, ) -> Weight {
(0 as Weight)
(2_505_000 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big jump from 0

@@ -77,9 +77,9 @@ impl<T: frame_system::Config> pallet_scheduler::WeightInfo for WeightInfo<T> {
// Storage: Preimage StatusFor (r:1 w:1)
/// The range of component `s` is `[1, 50]`.
fn on_initialize_periodic_resolved(s: u32, ) -> Weight {
(2_421_000 as Weight)
(0 as Weight)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big jump down from 2_421_000 to 0

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on SWC.
Only one actually up 13.6% is kusama cancel_deferred_slash, but that should be fine.

@coderobe coderobe merged commit 314298c into release-v0.9.28 Aug 23, 2022
@coderobe coderobe deleted the coderobe/weights-28 branch August 23, 2022 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants