Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

add swapped event to registrar #5990

Merged
merged 10 commits into from
May 3, 2023
Merged

add swapped event to registrar #5990

merged 10 commits into from
May 3, 2023

Conversation

brunopgalvao
Copy link
Contributor

This PR adds a Swapped event to the paras_registrar.

This can be helpful to let others know that a swap has occurred.

@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Sep 9, 2022
bkchr
bkchr approved these changes Sep 10, 2022
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could check for this event in the tests

@brunopgalvao
Copy link
Contributor Author

You could check for this event in the tests

I see many examples of verifying events in benchmarking but not in tests. Do we have an example that I can take a look at?

@ggwpez
Copy link
Member

ggwpez commented Sep 12, 2022

I see many examples of verifying events in benchmarking but not in tests. Do we have an example that I can take a look at?

Yea tons of it. You can search the code-base for assert_last_event.

shawntabrizi
shawntabrizi approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you need help writing a test, let me know.

@brunopgalvao
Copy link
Contributor Author

@shawntabrizi that would be great. I committed some code - I will leave some comments.. Any feedback would be appreciated.

@brunopgalvao brunopgalvao added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. label Mar 23, 2023
@brunopgalvao brunopgalvao marked this pull request as draft March 23, 2023 11:41
@brunopgalvao brunopgalvao added B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. T1-runtime This PR/Issue is related to the topic “runtime”. labels Mar 23, 2023
@brunopgalvao
Copy link
Contributor Author

Will solve issue #5562

@brunopgalvao brunopgalvao marked this pull request as ready for review April 22, 2023 09:57
@brunopgalvao brunopgalvao requested review from ggwpez and shawntabrizi and removed request for shawntabrizi April 22, 2023 09:59
@brunopgalvao brunopgalvao requested review from liamaharon and removed request for shawntabrizi April 25, 2023 23:04
@brunopgalvao
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 81456c8 into master May 3, 2023
@paritytech-processbot paritytech-processbot bot deleted the bg/swapped-event branch May 3, 2023 13:13
@xlc xlc mentioned this pull request May 3, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
@kiltbot kiltbot mentioned this pull request Jun 21, 2023
Closed
@brunopgalvao brunopgalvao mentioned this pull request Oct 20, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@liamaharon liamaharon liamaharon approved these changes

@shawntabrizi shawntabrizi shawntabrizi approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brunopgalvao @ggwpez @shawntabrizi @bkchr @liamaharon