Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix fuzzing builds xcm-fuzz and erasure-coding fuzzer #6153

Merged
merged 3 commits into from
Oct 16, 2022
Merged

Fix fuzzing builds xcm-fuzz and erasure-coding fuzzer #6153

merged 3 commits into from
Oct 16, 2022

Conversation

code-terror
Copy link
Contributor

include polkadot-primitives in erasure-coding to build fuzzer..
Change honggfuzz to 0.5.55 from 0.5.54 for a straightforward build and include honggfuzz in fuzz.rs

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Oct 14, 2022

User @commented-line, please sign the CLA here.

@code-terror
Copy link
Contributor Author

@eskimor @sandreim @rphmeier @pepoviola

ordian
ordian approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

You need to update the Cargo.lock(s) as well.

@ordian ordian added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Oct 14, 2022
@code-terror
Copy link
Contributor Author

@ordian @sandreim changed cargo.lock

@ordian
Copy link
Member

ordian commented Oct 15, 2022

The compilation fails:

error: unused import: `honggfuzz::fuzz`
  --> xcm/xcm-simulator/fuzzer/src/fuzz.rs:30:5
   |
30 | use honggfuzz::fuzz;

Because fuzz! macro is only used when fuzzing feature is enabled.
I'd suggest to remove the use statement and replace fuzz! with fully qualified path honggfuzz::fuzz!.

@ordian

This comment was marked as resolved.

Sign in to view
@code-terror
Copy link
Contributor Author

@ordian changed use statement

@ordian
Copy link
Member

ordian commented Oct 16, 2022

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 828fa9e into paritytech:master Oct 16, 2022
ordian added a commit that referenced this pull request Oct 21, 2022
@ordian
Merge branch 'master' into giles-common-version
ecd7b49 
* master: (21 commits)
  try and fix build (#6170)
  Companion for EPM duplicate submissions (#6115)
  Bump docker/setup-buildx-action from 2.0.0 to 2.1.0 (#6141)
  companion for #12212 (#6162)
  Bump substrate (#6164)
  BlockId removal: refactor: StorageProvider (#6160)
  availability-recovery: use `IfDisconnected::TryConnect` for chunks (#6081)
  Update clap to version 4 (#6128)
  Add `force_open_hrmp_channel` Call (#6155)
  Fix fuzzing builds xcm-fuzz and erasure-coding fuzzer (#6153)
  BlockId removal refactor: Backend::state_at (#6149)
  First round of implementers guide fixes (#6146)
  bump zombienet version (#6142)
  lingua.dic is not managed by CI team (#6148)
  pallet-mmr: RPC and Runtime APIs work with block numbers (#6072)
  Separate preparation timeouts for PVF prechecking and execution (#6139)
  Malus: add disputed block percentage (#6100)
  refactor grid topology to expose more info to subsystems (#6140)
  Manual Para Lock (#5451)
  Expose node subcommands in Malus CLI (#6135)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandreim sandreim sandreim approved these changes

@ordian ordian ordian approved these changes

Assignees
No one assigned
Labels
B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@code-terror @ordian @sandreim @commented-line