Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactors elections-phragmen pallet (companion for substrate#13453) #6278

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

Refactors elections-phragmen pallet (companion for substrate#13453) #6278

wants to merge 45 commits into from

Conversation

gpestana
Copy link
Contributor

@gpestana gpestana commented Nov 13, 2022 •
edited
Loading

Companion for paritytech/substrate#13453

Cumulus companion: paritytech/cumulus#2217

@gpestana gpestana marked this pull request as draft November 13, 2022 17:18
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Nov 13, 2022
@paritytech-ci paritytech-ci requested review from a team November 13, 2022 17:18
@gpestana gpestana mentioned this pull request Nov 13, 2022
Merged
6 tasks
@gpestana gpestana added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Nov 14, 2022
kianenigma
kianenigma suggested changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely want to see a good amount of doc about the pallet prefix, and hot it could lead to a migration, and how we won't need it here.

@gpestana gpestana requested a review from kianenigma November 20, 2022 15:02
@gpestana gpestana added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Nov 20, 2022
@gpestana gpestana marked this pull request as ready for review November 20, 2022 16:09
@paritytech-ci paritytech-ci requested a review from a team November 20, 2022 16:09
@kianenigma
Copy link
Contributor

Needs to be brought back to life.

@gpestana gpestana added B1-releasenotes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. and removed B1-releasenotes labels Dec 8, 2022
@gpestana gpestana self-assigned this Dec 8, 2022
@the-right-joyce the-right-joyce added B1-note_worthy T0-node This PR/Issue is related to the topic “node”. T1-runtime This PR/Issue is related to the topic “runtime”. labels Dec 14, 2022
kianenigma
kianenigma reviewed Jan 16, 2023
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should keep the old pallet name in Polkadot and Kusama runtimes, but the crate name can still change.

@paritytech-ci paritytech-ci requested a review from a team January 16, 2023 19:10
@gpestana
Copy link
Contributor Author

bot bench -v PATCH_substrate=13453 $ runtime polkadot-dev pallet_elections

@command-bot
Copy link

command-bot bot commented Mar 24, 2023 •
edited
Loading

@gpestana "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot-dev pallet_elections (https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583564) was cancelled in #6278 (comment)

@gpestana
Copy link
Contributor Author

bot cancel 38-d29b67b0-4859-4765-a173-1c90c2ac9602

@command-bot
Copy link

command-bot bot commented Mar 24, 2023

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583564 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583564/artifacts/download.

@gpestana
Copy link
Contributor Author

bot bench -v PATCH_substrate=13453 $ runtime polkadot-dev pallet_elections

@command-bot
Copy link

command-bot bot commented Mar 24, 2023 •
edited
Loading

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583937 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot-dev pallet_elections. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 39-a5a4e7fa-9118-4938-930b-fbfbe5dda7f7 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 24, 2023

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime polkadot-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583937 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2583937/artifacts/download.

@gpestana
Copy link
Contributor Author

bot bench -v PATCH_substrate=13453 $ runtime kusama-dev pallet_elections

@command-bot
Copy link

command-bot bot commented Mar 24, 2023 •
edited
Loading

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2587655 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 42-ac6a1209-f80e-4098-ad36-f4455ec315a4 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 24, 2023

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2587655 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2587655/artifacts/download.

@gpestana
Copy link
Contributor Author

bot bench -v PATCH_substrate=13453 $ runtime kusama-dev pallet_elections

@command-bot
Copy link

command-bot bot commented Mar 25, 2023 •
edited
Loading

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2590313 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 45-d72dd759-7703-4cd3-8bed-cacb3cabcd59 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Mar 25, 2023

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2590313 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2590313/artifacts/download.

@kianenigma kianenigma self-requested a review April 10, 2023 12:26
@gpestana
Copy link
Contributor Author

gpestana commented May 1, 2023

bot bench -v PATCH_substrate=13453 $ runtime kusama-dev pallet_elections

@command-bot
Copy link

command-bot bot commented May 1, 2023 •
edited
Loading

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2756720 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-845e819a-e3a2-45ec-8f93-fba2d93b6801 to cancel this command or bot cancel to cancel all commands in this pull request.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2756531

@command-bot
Copy link

command-bot bot commented May 1, 2023

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2756720 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2756720/artifacts/download.

@gpestana
Copy link
Contributor Author

gpestana commented May 1, 2023

bot bench -v PATCH_substrate=13453 $ runtime kusama-dev pallet_elections

@command-bot
Copy link

command-bot bot commented May 1, 2023 •
edited
Loading

@gpestana https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2757705 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections. Check out https://gitlab.parity.io/parity/mirrors/polkadot/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 10-67ac322a-f028-4e0f-9619-db03e0062f66 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 1, 2023

@gpestana Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" runtime kusama-dev pallet_elections has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2757705 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2757705/artifacts/download.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov

@Ank4n Ank4n Awaiting requested review from Ank4n

@shawntabrizi shawntabrizi Awaiting requested review from shawntabrizi

@rossbulat rossbulat Awaiting requested review from rossbulat

@kianenigma kianenigma Awaiting requested review from kianenigma

At least 1 approving review is required to merge this pull request.

Assignees

@gpestana gpestana

Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D5-nicetohaveaudit ⚠️ PR contains trivial changes to logic that should be properly reviewed. T0-node This PR/Issue is related to the topic “node”.
Projects
Security Audit (PRs) - SRLabs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gpestana @kianenigma @rossbulat @paritytech-cicd-pr @shawntabrizi @bkchr @the-right-joyce