This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Log UnknownBlock errors from runtime
#6288
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdimitrov
changed the title
UnknownBlock error during runtime calls gracefullyUnknownBlock error from runtime calls gracefully
github-actions
bot
added
the
A3-in_progress
tdimitrov
force-pushed
the
tsv-state-discarded
branch
from
b47211f to
0caf316
Compare
tdimitrov
force-pushed
the
tsv-state-discarded
branch
from
0caf316 to
7b092d7
Compare
tdimitrov
force-pushed
the
tsv-state-discarded
branch
from
8e3a664 to
838c089
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
tdimitrov
changed the title
UnknownBlock error from runtime calls gracefullyUnknownBlock errors from runtime
2 tasks
tdimitrov
added
A0-please_review
|
What is the rationale for using
How is it possible to do that in general case? Wouldn't you have a TOCTOU problem? |
ordian
approved these changes
Feb 2, 2023
BradleyOlson64
approved these changes
Feb 2, 2023
|
These logs doesn't contribute much to the understandably of the logs. I'm closing the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is building upon paritytech/substrate#12707 and is related to paritytech/polkadot-sdk#793
The problem
All runtime calls first check the runtime version before issuing the actual runtime api call. If a call is made for a block which is pruned (e.g. because a better fork was finalized), the runtime api version can't be checked and
NotSupportederror is returned. This is misleading because the problem is different. The call IS supported but it can't be executed at a pruned block.How this is solved
This PR adds explicit logging for
UnknownBlockruntime errors so that it is clear why the runtime call is failing. FurthermoreUnknownBlockvariant is added toRuntimeApiErrorenum innode/subsystem-types/src/errors.rs. This allows any subsystem to handle such errors in its own way.What this PR doesn't do
The PR doesn't fix the root cause (prevent executing logic on pruned blocks).
Sample logs
E.g. for
{node=~"versi-validator-f.*"} |~ "UnknownBlock|discarded":