This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Westend state trie to version 1 #6336
Merged
paritytech-processbot
merged 15 commits into
paritytech:master
from
cheme:westend-migration
Jan 11, 2023
+72
−1
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
a6b43bd
Switch to state V1 and add state-trie-migration pallet with dummy manual
cheme 98eb976
Initialize limit on runtime upgrade.
cheme 6dda492
add prelude
cheme 0d01e51
sp_std prelude only for no_std
cheme a94fc6a
Disable filter for signed migration
cheme e9c4cdf
revert hex dep
cheme 21c9093
use NeverEnsureOrigin
cheme 1b1ed4a
Merge branch 'master' into westend-migration
cheme 93a70d0
Merge branch 'master' into westend-migration
cheme 9b75e96
fix
cheme f9c7796
correct fix
cheme 84416a8
Merge remote-tracking branch 'origin/master' into westend-migration
24ede00
check init state in try-runtime
cheme b48585c
Merge branch 'master' into westend-migration
cheme 99ed695
Merge branch 'master' into westend-migration
cheme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Switch to state V1 and add state-trie-migration pallet with dummy manual
account.
commit a6b43bd41663d1cc3e6bb1d3061a76378bd2a0c1
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we are running an automatic migration, do we need the controller account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but I did not find a good way to disable its declaration (I tried to replace it with Sudo but the types are differents).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you not set signedfilter to ensure root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I tried, but got
expected struct
_sp_runtime::AccountId32, found
()``.Just SignedOrigin got a constraint
Success = Self::AccountId
.Starting trying to map to a dummy account without creating a new controller, but end up thinking that if I would be using a dummy account anyway.
But maybe I can local implement a noop `EnsureOrigin` (thinking twice this looks more harmless than allowing someone even if we know noone have the key).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this instead a94fc6a