Issue 6274: keeping all backing votes in provisioner vote set

[BradleyOlson64]

No description provided.

[ordian]

The problem with always importing backing statements is that runtime dispute filtering code will discard any sets with duplicate votes. So we need to modify the runtime first to allow passing duplicate backing statements I guess?

[BradleyOlson64]

The problem with always importing backing statements is that runtime dispute filtering code will discard any sets with duplicate votes. So we need to modify the runtime first to allow passing duplicate backing statements I guess?

So perhaps I should create a separate pr containing the runtime changes and get that merged first?

[ordian]

Upon further inspection, it seems my initial comment was wrong:

polkadot/runtime/parachains/src/disputes.rs

Line 939 in 6a5d31f

// Votes which are duplicate or already known by the chain are filtered out.

polkadot/runtime/parachains/src/disputes.rs

Line 1002 in 6a5d31f

filter.remove_index(i);

[tdimitrov]

Good job! Check the tests - resume_dispute_without_local_statement is failing.

[paritytech-processbot]

Error: Statuses failed for 8fc43b5

[mrcnski]

nit: Your version is totally fine, but I think you can also do something like this 🙂 (haven't checked it):

Suggested change

	if let Some(kind) = valid_kind {
	match kind {
	ValidDisputeStatementKind::BackingValid(_) => return true,
	ValidDisputeStatementKind::BackingSeconded(_) => return true,
	_ => (),
	}
	}
	if matches!(valid_kind, Some(ValidDisputeStatementKind::BackingValid(_) | ValidDisputeStatementKind::BackingSeconded(_)) {
	return true
	}

[mrcnski]

Make sure you add Closes #6274 to the description, so the issue gets closed automatically.

[BradleyOlson64]

Good job! Check the tests - resume_dispute_without_local_statement is failing.

Could use a second pair of eyes on this. It seems like the chain scraper is asking for block ancestors when we don't expect it to.

Thing is, for the life of me I can't figure out how keeping backing votes in the provisioner effects this at all.

The failing test doesn't even include any backing votes, so it seems like my changes wouldn't come into play.

[BradleyOlson64]

bot merge

[paritytech-processbot]

Waiting for commit status.