This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[DNM] scale testing #6530
Closed
[DNM] scale testing #6530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Only needed for approval voting, but no way to do it granularly. Good enough for a test. Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…ates. Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…view updates." This reverts commit 1aa0bd2. Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
the-right-joyce
added
A3-in_progress
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…/all_subsystems_blocking
This reverts commit 4d4fbc3.
unconstrained task for pov recovery. Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…/all_subsystems_blocking
sergejparity
reviewed
Feb 3, 2023
Comment on lines
+54
to
+55
| let keysytore = test_helpers::mock::make_ferdie_keystore(); | ||
| let subsystem = ApprovalDistribution::new(Default::default(), keysytore); |
There was a problem hiding this comment.
Of course this is WIP. Just noticed strange var name "keysytore". Is it not by chance?
There was a problem hiding this comment.
nice catch, lol, typo. This is throw away changes mostly, just for testing purposes.
sergejparity
reviewed
Feb 3, 2023
Comment on lines
+2288
to
+2289
| let keysytore = test_helpers::mock::make_ferdie_keystore(); | ||
| let subsystem = ApprovalDistribution::new(Default::default(), keysytore); |
There was a problem hiding this comment.
Of course this is WIP. Just noticed strange var name "keysytore". Is it not by chance?
This was referenced Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.